Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename remaining "Eval" to "Interp" #61625

Merged
merged 3 commits into from
Jun 8, 2019
Merged

Rename remaining "Eval" to "Interp" #61625

merged 3 commits into from
Jun 8, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 7, 2019

Renaming done by sed.

r? @oli-obk

Fixes #54395.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2019
@RalfJung RalfJung mentioned this pull request Jun 7, 2019
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Jun 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jun 7, 2019

📌 Commit 3aca71f has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 7, 2019
@Centril
Rollup merge of rust-lang#61625 - RalfJung:eval-interp, r=oli-obk
86f392c 
Rename remaining "Eval" to "Interp"

Renaming done by sed.

r? @oli-obk

Fixes rust-lang#54395.
@Centril Centril mentioned this pull request Jun 7, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 7, 2019
@Centril
Rollup merge of rust-lang#61625 - RalfJung:eval-interp, r=oli-obk
5d1896b 
Rename remaining "Eval" to "Interp"

Renaming done by sed.

r? @oli-obk

Fixes rust-lang#54395.
@Centril Centril mentioned this pull request Jun 7, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Jun 7, 2019

Failed in #61637 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Jun 8, 2019

This was caused by a conflict. I rebased.

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 8, 2019

📌 Commit b86c050 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 8, 2019
@bors
Copy link
Contributor

bors commented Jun 8, 2019

⌛ Testing commit b86c050 with merge 5c45343...

bors added a commit that referenced this pull request Jun 8, 2019
@bors
Auto merge of #61625 - RalfJung:eval-interp, r=oli-obk
5c45343 
Rename remaining "Eval" to "Interp"

Renaming done by sed.

r? @oli-obk

Fixes #54395.
@bors
Copy link
Contributor

bors commented Jun 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 5c45343 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 8, 2019
@bors bors merged commit b86c050 into rust-lang:master Jun 8, 2019
@rust-highfive rust-highfive mentioned this pull request Jun 8, 2019
Closed
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #61625!

Tested on commit 5c45343.
Direct link to PR: #61625

💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 8, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#61625!
9234dd8 
Tested on commit rust-lang/rust@5c45343.
Direct link to PR: <rust-lang/rust#61625>

💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
This was referenced Jun 8, 2019
Merged
Closed
Closed
Merged
@RalfJung RalfJung deleted the eval-interp branch June 9, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get the eval out of miri engine
5 participants
@RalfJung @oli-obk @bors @Centril @rust-highfive