Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Comment out dev key #61700

Merged
merged 2 commits into from
Jun 24, 2019
Merged

[beta] Comment out dev key #61700

merged 2 commits into from
Jun 24, 2019

Conversation

Mark-Simulacrum
Copy link
Member

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 10, 2019

📌 Commit 494f685 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019
@bors
Copy link
Contributor

bors commented Jun 13, 2019

⌛ Testing commit 494f685 with merge bf913ebb300e0cbb82fe468e760a1ab4c5c9b974...

@bors
Copy link
Contributor

bors commented Jun 13, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 13, 2019
@pietroalbini
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2019
@pietroalbini pietroalbini mentioned this pull request Jun 22, 2019
Merged
@pietroalbini
Copy link
Member

@bors r=alexcrichton p=-1

That seemed spurious.

@bors
Copy link
Contributor

bors commented Jun 22, 2019

📌 Commit 494f685 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2019
@bors
Copy link
Contributor

bors commented Jun 23, 2019

⌛ Testing commit 494f685 with merge 6af96f0187366baa5355f8003e1bb19fdbaeba13...

@bors
Copy link
Contributor

bors commented Jun 23, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2019
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:05:57]   libx32gcc1 libx32gomp1 libx32itm1 libx32quadmath0 libx32stdc++6 libx32ubsan0
[00:05:57]   pinentry-curses python-apt-common python3-apt python3-dbus python3-gi
[00:05:57]   python3-software-properties
[00:05:57] Suggested packages:
[00:05:57]   dbus-user-session libpam-systemd pinentry-gnome3 tor scdaemon isoquery
[00:05:57]   gmp-doc libgmp10-doc libmpfr-doc pinentry-doc python3-apt-dbg python-apt-doc
[00:05:57] Recommended packages:
[00:05:57]   gnupg dbus nodejs-doc unattended-upgrades
[00:05:57] The following NEW packages will be installed:
[00:05:57]   dirmngr gcc-7-multilib gcc-multilib gir1.2-glib-2.0 gpg gpg-agent gpgconf
---
[00:06:08] Setting up python3-dbus (1.2.6-1) ...
[00:06:08] Setting up libx32cilkrts5 (7.4.0-1ubuntu1~18.04.1) ...
[00:06:08] Setting up nodejs (8.10.0~dfsg-2ubuntu0.4) ...
[00:06:08] update-alternatives: using /usr/bin/nodejs to provide /usr/bin/js (js) in auto mode
[00:06:08] update-alternatives: warning: skip creation of /usr/share/man/man1/js.1.gz because associated file /usr/share/man/man1/nodejs.1.gz (of link group js) doesn't exist
[00:06:08] Setting up libx32ubsan0 (7.4.0-1ubuntu1~18.04.1) ...
[00:06:08] Setting up gpgconf (2.2.4-1ubuntu1.2) ...
[00:06:08] Setting up lib32asan4 (7.4.0-1ubuntu1~18.04.1) ...
[00:06:08] Setting up lib32mpx2 (8.3.0-6ubuntu1~18.04.1) ...
---
[00:06:12]  ---> f5673db17933
[00:06:12] Step 6/40 : RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
[00:06:12]  ---> Running in e37cf6af88e4
[00:06:13] Warning: apt-key output should not be parsed (stdout is not a terminal)
[00:06:13] Executing: /tmp/apt-key-gpghome.xWJBx69nEr/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
[00:06:13] gpg: Total number processed: 1
[00:06:13] gpg:               imported: 1
[00:06:14] Removing intermediate container e37cf6af88e4
[00:06:14]  ---> 6837a880fcf7

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

I think this'll need to backport #61055 to work

@Mark-Simulacrum
Copy link
Member Author

I'll try to get around to that in a bit -- maybe tomorrow -- but feel free to push to my PR if someone gets a chance to before then.

@bgermann @Mark-Simulacrum
Solaris CI: Build with dilos2 stable
4379216 
dilos2-testing has problems since the last repository update, so get the packages from dilos2 stable.

Fixes rust-lang#61022.
@Mark-Simulacrum
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jun 23, 2019

📌 Commit 4379216 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2019
@bors
Copy link
Contributor

bors commented Jun 24, 2019

⌛ Testing commit 4379216 with merge a91f2e5...

bors added a commit that referenced this pull request Jun 24, 2019
@bors
Auto merge of #61700 - Mark-Simulacrum:beta-non-dev, r=alexcrichton
a91f2e5 
[beta] Comment out dev key

r? @alexcrichton or @pietroalbini
@bors
Copy link
Contributor

bors commented Jun 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing a91f2e5 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 24, 2019
@bors bors merged commit 4379216 into rust-lang:beta Jun 24, 2019
bors added a commit that referenced this pull request Jun 26, 2019
@bors
Auto merge of #62065 - pietroalbini:beta-rollup, r=Mark-Simulacrum
83167c4 
[beta] Rollup backports

Rolled up:

* [beta] Comment out dev key #61700

Cherry picked:

* Dont ICE on an attempt to use GAT without feature gate #61118
* Fix cfg(test) build for x86_64-fortanix-unknown-sgx #61503
* Handle index out of bound errors during const eval without panic #61598
* Hygienize macros in the standard library #61629
* Fix ICE involving mut references #61947
* rustc_typeck: correctly compute `Substs` for `Res::SelfCtor`. #61896
* Revert "Set test flag when rustdoc is running with --test option" #61199
* create a "provisional cache" to restore performance in the case of cycles #61754

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mark-Simulacrum @rust-highfive @alexcrichton @bors @pietroalbini @bgermann