rustc: remove 'x: 'y bounds (except where necessary or from comments/strings). #61891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Jun 16, 2019
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Jun 17, 2019
oli-obk
reviewed
Jun 17, 2019
oli-obk
reviewed
Jun 17, 2019
| @@ -1,4 +1,4 @@ | |||
| thread 'rustc' panicked at 'assertion failed: rows.iter().all(|r| r.len() == v.len())', src/librustc_mir/hair/pattern/_match.rs:1084:5 | |||
There was a problem hiding this comment.
hmm... I could make compiletest detect ICEs automatically and filter the line/col info
|
@bors r+ |
|
📌 Commit 2be847b has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 bitrotty |
bors
added a commit
that referenced
this pull request
Jun 18, 2019
rustc: remove 'x: 'y bounds (except where necessary or from comments/strings). This PR removes all lifetime-lifetime "outlives" bounds (e.g. `'tcx: 'a`) bounds except a few necessary ones (see the `reintroduce lifetime bounds where necessary` commit). Some of these bounds kept around otherwise-unused lifetimes (e.g. `<'a, 'tcx: 'a>` followed by uses of `'tcx` but not `'a`) - these lifetimes (i.e. `'a`) were then removed. (maybe they should be considered unused by the lint? cc @matthewjasper @zackmdavis) r? @oli-obk cc @rust-lang/compiler
|
☀️ Test successful - checks-travis, status-appveyor |
3 tasks
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 18, 2019
Tested on commit rust-lang/rust@04a3dd8. Direct link to PR: <rust-lang/rust#61891> 💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra). 🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
This was referenced Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all lifetime-lifetime "outlives" bounds (e.g.
'tcx: 'a) bounds except a few necessary ones (see thereintroduce lifetime bounds where necessarycommit).Some of these bounds kept around otherwise-unused lifetimes (e.g.
<'a, 'tcx: 'a>followed by uses of'tcxbut not'a) - these lifetimes (i.e.'a) were then removed.(maybe they should be considered unused by the lint? cc @matthewjasper @zackmdavis)
r? @oli-obk cc @rust-lang/compiler