Implement the new for-loop protocol #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exciting! 🚴 |
|
needs a rebase, but I'm into it! thanks :) |
|
Should be all good to go now. |
|
I thought I had run all the tests, but apparently not. I've got |
bors
added a commit
that referenced
this pull request
May 11, 2013
Closes #6183. The first commit changes the compiler's method of treating a `for` loop, and all the remaining commits are just dealing with the fallout. The biggest fallout was the `IterBytes` trait, although it's really a whole lot nicer now because all of the `iter_bytes_XX` methods are just and-ed together. Sadly there was a huge amount of stuff that's `cfg(stage0)` gated, but whoever lands the next snapshot is going to have a lot of fun deleting all this code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6183.
The first commit changes the compiler's method of treating a
forloop, and all the remaining commits are just dealing with the fallout.The biggest fallout was the
IterBytestrait, although it's really a whole lot nicer now because all of theiter_bytes_XXmethods are just and-ed together. Sadly there was a huge amount of stuff that'scfg(stage0)gated, but whoever lands the next snapshot is going to have a lot of fun deleting all this code!