Clarify unaligned fields in ptr::{read,write}_unaligned #62323
Conversation
rust-highfive
added
the
S-waiting-on-review
|
|
Centril
force-pushed
the
clarify-read-unaligned
branch
from
1fb34b7
to
de9297e
Compare
Centril
changed the title
Centril
force-pushed
the
clarify-read-unaligned
branch
from
de9297e
to
b156356
Compare
Centril
force-pushed
the
clarify-read-unaligned
branch
from
b156356
to
bee964c
Compare
|
Please don't force-push while review is still in progress, unless necessary for a rebase. (a) force-pushes don't trigger email notifications, and (b) that makes it harder to figure out what changed since the last review. (I am aware that GitHub shows those diffs, but e.g. it does not show the full diff when you do multiple force-pushes in a row.) rust-highfive even says this when welcoming new users, but I guess it's been a while since you got that message. ;) |
No, but a comment in thread does, which I did make... ;)
It does, you can click on each "force-push" link in sequence and it will show the relative diff. I am aware that force pushing makes it harder to figure out what changed since last review when the diff and PR is large (and then I wouldn't do it) but in this case it's small, so a cleaner history is imo to be preferred. |
That is incorrect. When you do two force-pushes in a row with no other event in between, GH will just say "force-pushed twice, most recently from X to Y", with no way to get the full diff.
You can squash after I am done with reviewing. But please don't while review is still in progress. Please follow the process we also expect new contributors to follow. |
|
Thanks a lot! r=me, after squashing if you want. |
|
Too much going on today... so I'll just... @bors r=RalfJung rollup |
|
📌 Commit 54527db has been approved by |
bors
added
S-waiting-on-bors
…alfJung
Clarify unaligned fields in ptr::{read,write}_unaligned
r? @RalfJung
…alfJung
Clarify unaligned fields in ptr::{read,write}_unaligned
r? @RalfJung
…alfJung
Clarify unaligned fields in ptr::{read,write}_unaligned
r? @RalfJung
Rollup of 10 pull requests Successful merges: - #62123 ( Remove needless lifetimes (std)) - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.) - #62169 (Derive which queries to save using the proc macro) - #62238 (Fix code block information icon position) - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`) - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned) - #62324 (Reduce reliance on `await!(...)` macro) - #62371 (Add tracking issue for Box::into_pin) - #62383 (Improve error span for async type inference error) - #62388 (Break out of the correct number of scopes in loops) Failed merges: r? @ghost
…unaligned, r=rkruppe rust-lang#62357: doc(ptr): add example for {read,write}_unaligned related to rust-lang#62357 > With rust-lang#62323 the only example (that had UB and was thus invalid) in std::ptr::read_unaligned and std::ptr::write_unaligned is removed. > We should add a valid example of using the aforementioned functions. Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
r? @RalfJung