-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compile-pass
from compiletest
#62369
Conversation
Should we also modify these lines? rust/src/librustc_mir/error_codes.rs Line 334 in b43eb42
rust/src/librustc_mir/error_codes.rs Line 363 in b43eb42
|
Not sure; r? @petrochenkov |
@JohnTitor
As I understand, those |
@petrochenkov I opened rust-lang/rustc-dev-guide#380 , could you review it?
Okay, I don't touch this time. |
Why not?
Could you update the rustc-guide submodule in this PR. |
Okay, I'll fix, we should only remove |
removed |
@bors r+ |
📌 Commit 3adad33 has been approved by |
…trochenkov Remove `compile-pass` from compiletest This is a part of rust-lang#62277. Removes `compile-pass` from compiletest (and modify some tests' annotations). r? @Centril
@bors r- The test |
Also change annotations in some tests
3adad33
to
1640ab2
Compare
@Centril Don't worry, I modified test annotation to |
Thanks! @bors r=petrochenkov |
📌 Commit 1640ab2 has been approved by |
…trochenkov Remove `compile-pass` from compiletest This is a part of rust-lang#62277. Removes `compile-pass` from compiletest (and modify some tests' annotations). r? @Centril
…trochenkov Remove `compile-pass` from compiletest This is a part of rust-lang#62277. Removes `compile-pass` from compiletest (and modify some tests' annotations). r? @Centril
Rollup of 13 pull requests Successful merges: - #61545 (Implement another internal lints) - #62110 (Improve -Ztime-passes) - #62133 (Feature gate `rustc` attributes harder) - #62158 (Add MemoryExtra in InterpretCx constructor params) - #62168 (The (almost) culmination of HirIdification) - #62193 (Create async version of the dynamic-drop test) - #62369 (Remove `compile-pass` from compiletest) - #62380 (rustc_target: avoid negative register counts in the SysV x86_64 ABI.) - #62381 (Fix a typo in Write::write_vectored docs) - #62390 (Update README.md) - #62396 (remove Scalar::is_null_ptr) - #62406 (Lint on invalid values passed to x.py --warnings) - #62414 (Remove last use of mem::uninitialized in SGX) Failed merges: r? @ghost
This is a part of #62277.
Removes
compile-pass
from compiletest (and modify some tests' annotations).r? @Centril