Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never_type feature requirement for exhaustive patterns #62405

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

hellow554
Copy link
Contributor

I think this resolves #51221
At least for me, it doesn't ICE anymore and all tests are still passing, so LGTM

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2019
@hellow554 hellow554 force-pushed the patch-1 branch 2 times, most recently from 519cf9f to ee6ea83 Compare July 5, 2019 20:14
@hellow554
Copy link
Contributor Author

Done, waiting for travis azure

@hellow554
Copy link
Contributor Author

@nikomatsakis do you have time for this, or should I pick another reviewer?

@hellow554
Copy link
Contributor Author

@Dylan-DPC can you assign a new reviewer please?

@Dylan-DPC-zz
Copy link

@hellow554 sure. can someone from @rust-lang/compiler review this?

@varkor
Copy link
Member

varkor commented Jul 15, 2019

As far as I can tell, when the exhaustive_patterns feature gate was added the never_type requirement was superseded, but was never removed, so this looks correct.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 15, 2019

📌 Commit ff67b90 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 15, 2019
Remove never_type feature requirement for exhaustive patterns

I **think** this resolves rust-lang#51221
At least for me, it doesn't ICE anymore and all tests are still passing, so LGTM
bors added a commit that referenced this pull request Jul 16, 2019
Rollup of 14 pull requests

Successful merges:

 - #62103 (Add debug assertions to write_bytes and copy*)
 - #62405 (Remove never_type feature requirement for exhaustive patterns)
 - #62491 (Fix Pin urls in Option documentation)
 - #62533 (Add missing links for CannotReallocInPlace type)
 - #62634 (Less unsafe in the array example of MaybeUninit docs)
 - #62639 (Make VaListImpl<'f> invariant over the 'f lifetime)
 - #62646 (Tweak wording in feature gate errors)
 - #62662 (add spaces in front of trait requirements in libcore/cell.rs)
 - #62668 (Fix #62660)
 - #62673 (miri validation: better error messages for dangling references)
 - #62680 (Actually call `visit_block_entry` in `DataflowResultsConsumer`)
 - #62685 (Add info about undefined behavior to as_ref suggestions)
 - #62689 (Fix typo in RawWaker::new documentation)
 - #62698 (SGX target: don't pretend to be GNU/Linux to LLVM)

Failed merges:

r? @ghost
@bors bors merged commit ff67b90 into rust-lang:master Jul 16, 2019
@hellow554 hellow554 deleted the patch-1 branch July 16, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE when using exhaustive_patterns without never_type
7 participants