Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only error about MSVC + PGO + unwind if we're generating code #62615

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Only error about MSVC + PGO + unwind if we're generating code #62615

merged 2 commits into from
Jul 18, 2019

Commits on Jul 12, 2019

  1. Revert "Emit warning when trying to use PGO in conjunction with unwin… 

    …ding on Windows."

This reverts commit 74a39a3.
    @wesleywiser
    wesleywiser committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    374daa7 View commit details
    Browse the repository at this point in the history

  2. Only error about MSVC + PGO + unwind if we're generating code 

    When `rustc` is invoked with the `--print` argument, we don't actually
generate any code (unless it's the `native-static-libs` option). So we
don't need to error our in this case since there's no risk of generating
either LLVM assertions or corrupted binaries.
    @wesleywiser
    wesleywiser committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    3622311 View commit details
    Browse the repository at this point in the history