Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow LLVM to be pre-installed #62697

Closed
wants to merge 1 commit into from

Conversation

ethomson
Copy link

Some machines may have LLVM installed already; use an environment
variable to avoid attempting to reinstall.

Some machines may have LLVM installed already; use an environment
variable to avoid attempting to reinstall.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2019
@alexcrichton
Copy link
Member

I talked with @ethomson on chat and I think we probably don't want this long term, but this is necessary for now for testing some 4-core machine performance on Azure. I'm going to leave this open and depending on the results of the perf investigation we may end up adding this in one form or another.

@alexcrichton
Copy link
Member

Ok after more discussion and evaluation we ended up figuring that these executable installers are just too much of a pain to work with, so I'm going to close this in favor of our conclusion of "tarball install" in #62758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants