Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not use assume_init in std::io #62746

Merged
merged 3 commits into from
Jul 22, 2019
Merged

do not use assume_init in std::io #62746

merged 3 commits into from
Jul 22, 2019

Conversation

RalfJung
Copy link
Member

Cc #62397

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2019
@KodrAus
Copy link
Contributor

KodrAus commented Jul 17, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 17, 2019

📌 Commit 530651136c617ff952a93519f049e93ca6870464 has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

@bors r-

Will investigate CI failure.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2019
@RalfJung
Copy link
Member Author

This should do it.

@bors r=KodrAus

@bors
Copy link
Contributor

bors commented Jul 17, 2019

📌 Commit 20a6c68c6f1903140edf5c12142e04b1143c88e5 has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 18, 2019
Merged
bors added a commit that referenced this pull request Jul 18, 2019
@bors
Auto merge of #62782 - Mark-Simulacrum:rollup-1hz5ya6, r=Mark-Simulacrum
311376d 
Rollup of 15 pull requests

Successful merges:

 - #61926 (Fix hyperlinks in From impls between Vec and VecDeque)
 - #62615 ( Only error about MSVC + PGO + unwind if we're generating code)
 - #62696 (Check that trait is exported or public before adding hint)
 - #62712 (Update the help message on error for self type)
 - #62728 (Fix repeated wording in slice documentation)
 - #62730 (Consolidate hygiene tests)
 - #62732 (Remove last use of mem::uninitialized from std::io::util)
 - #62740 (Add missing link to Infallible in TryFrom doc)
 - #62745 (update data_layout and features for armv7-wrs-vxworks)
 - #62749 (Document link_section arbitrary bytes)
 - #62752 (Disable Z3 in LLVM build)
 - #62764 (normalize use of backticks in compiler messages for librustc/lint)
 - #62774 (Disable simd_select_bitmask test on big endian)
 - #62777 (Self-referencial type now called a recursive type)
 - #62778 (Emit artifact notifications for dependency files)

Failed merges:

 - #62746 ( do not use mem::uninitialized in std::io)

r? @ghost
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2019
@RalfJung RalfJung mentioned this pull request Jul 19, 2019
Merged
@RalfJung
Copy link
Member Author

RalfJung commented Jul 19, 2019 •
edited
Loading

A similar PR landed (#62732), but I think the solution here is better because it avoids by-value uninitialized integers (it avoids assume_init entirely). @KodrAus could you have another look?

Cc @nathanwhit @lzutao @Amanieu

@RalfJung RalfJung added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2019
@RalfJung RalfJung changed the title do not use mem::uninitialized in std::io do not use assume_init in std::io Jul 20, 2019
@KodrAus
Copy link
Contributor

KodrAus commented Jul 20, 2019

Hmm ok, I'm going to assume it's better for us to have only one set of open validity properties to consider here rather than two, and linking back to the tracking issue is nice so...

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2019

📌 Commit 7c1e405 has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 21, 2019
@Centril
Rollup merge of rust-lang#62746 - RalfJung:deprecated, r=KodrAus
9182b70 
 do not use assume_init in std::io

Cc rust-lang#62397
@Centril Centril mentioned this pull request Jul 21, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
@Centril
Rollup merge of rust-lang#62746 - RalfJung:deprecated, r=KodrAus
1d7faaf 
 do not use assume_init in std::io

Cc rust-lang#62397
@Centril Centril mentioned this pull request Jul 22, 2019
Merged
bors added a commit that referenced this pull request Jul 22, 2019
@bors
Auto merge of #62873 - Centril:rollup-ncnuelj, r=Centril
e649e90 
Rollup of 14 pull requests

Successful merges:

 - #62709 (Test that maplike FromIter satisfies uniqueness)
 - #62713 (Stabilize <*mut _>::cast and <*const _>::cast)
 - #62746 ( do not use assume_init in std::io)
 - #62787 (Fix typo in src/libstd/net/udp.rs doc comment)
 - #62788 (normalize use of backticks in compiler messages for libcore/ptr)
 - #62799 (use const array repeat expressions for uninit_array)
 - #62810 (normalize use of backticks in compiler messages for librustc_lint)
 - #62812 (normalize use of backticks in compiler messages for librustc_metadata)
 - #62832 (normalize use of backticks in compiler messages for librustc_incremental)
 - #62845 (read: fix doc comment)
 - #62853 (normalize use of backticks in compiler messages for librustc/hir)
 - #62854 (Fix typo in Unicode character name)
 - #62858 (Change wrong variable name.)
 - #62870 (fix lexing of comments with many \r)

Failed merges:

r? @ghost
@bors bors merged commit 7c1e405 into rust-lang:master Jul 22, 2019
@RalfJung RalfJung deleted the deprecated branch July 23, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KodrAus KodrAus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rust-highfive @KodrAus @bors