Skip to content

tests: Require run-pass tests without annotations to run successfully again #62797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/test/run-pass/backtrace-debuginfo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
// ignore-pretty issue #37195
// ignore-cloudabi spawning processes is not supported
// ignore-emscripten spawning processes is not supported
// normalize-stderr-test ".*\n" -> ""
// ignore-msvc issue #62844
// ignore-sgx no processes
// normalize-stderr-test ".*\n" -> ""

// Note that above `-opt-bisect-limit=0` is used to basically disable
// optimizations. It creates tons of output on stderr, hence we normalize
Expand Down
1 change: 1 addition & 0 deletions src/test/run-pass/backtrace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// ignore-cloudabi spawning processes is not supported
// ignore-emscripten spawning processes is not supported
// ignore-openbsd no support for libbacktrace without filename
// ignore-msvc issue #62844
// ignore-sgx no processes
// compile-flags:-g

Expand Down
5 changes: 5 additions & 0 deletions src/test/run-pass/command-uid-gid.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// ignore-android
// ignore-cloudabi
// ignore-emscripten
// ignore-sgx

#![feature(rustc_private)]

fn main() {
Expand Down
1 change: 1 addition & 0 deletions src/test/run-pass/generator/size-moved-locals.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
// See issue #59123 for a full explanation.

// edition:2018
// ignore-wasm32 issue #62807

#![feature(generators, generator_trait)]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Make sure that the mono-item collector does not crash when trying to
// instantiate a default impl for DecodeUtf16<<u8 as A>::Item>
// See https://github.com/rust-lang/rust/issues/58375

// build-pass
// compile-flags:-C link-dead-code

#![crate_type = "rlib"]
Expand All @@ -19,5 +21,4 @@ impl A for u8 {
type Item = char;
}

impl Arbitrary for DecodeUtf16<<u8 as A>::Item> {
}
impl Arbitrary for DecodeUtf16<<u8 as A>::Item> {}
4 changes: 3 additions & 1 deletion src/tools/compiletest/src/runtest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,10 @@ impl<'test> TestCx<'test> {
}

fn should_run_successfully(&self) -> bool {
let pass_mode = self.pass_mode();
match self.config.mode {
RunPass | Ui => self.pass_mode() == Some(PassMode::Run),
Ui => pass_mode == Some(PassMode::Run),
RunPass => pass_mode == Some(PassMode::Run) || pass_mode.is_none(),
mode => panic!("unimplemented for mode {:?}", mode),
}
}
Expand Down