Skip to content

Tweak span for variant not found error #62817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2019
+5 −4
Merged

Tweak span for variant not found error #62817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/librustc_typeck/astconv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,10 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
Applicability::MaybeIncorrect,
);
} else {
err.span_label(span, format!("variant not found in `{}`", qself_ty));
err.span_label(
assoc_ident.span,
format!("variant not found in `{}`", qself_ty),
);
}

if let Some(sp) = tcx.hir().span_if_local(adt_def.did) {
Expand Down
4 changes: 1 addition & 3 deletions src/test/ui/suggestions/suggest-variants.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ LL | enum Shape {
| ---------- variant `Rombus` not found here
...
LL | println!("My shape is {:?}", Shape::Rombus{ size: 5});
| -------^^^^^^
| |
| variant not found in `Shape`
| ^^^^^^ variant not found in `Shape`

error[E0599]: no variant or associated item named `Squareee` found for type `Shape` in the current scope
--> $DIR/suggest-variants.rs:15:12
Expand Down