Improve some pointer-related documentation #62822

RalfJung · 2019-07-20T11:20:41Z

No description provided.

…se drop

…t be non-NULL

rust-highfive · 2019-07-20T11:20:51Z

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

src/libstd/primitive_docs.rs

Centril · 2019-07-20T23:40:54Z

r? @Centril

…e it is dereferenced

src/libstd/primitive_docs.rs

Centril · 2019-07-22T13:27:05Z

Thanks! r=me rollup with #62822 (comment) addressed in some way.

Centril · 2019-07-22T19:50:19Z

@bors r+ rollup

bors · 2019-07-22T19:50:20Z

📌 Commit 9196781 has been approved by Centril

Improve some pointer-related documentation

src/libstd/primitive_docs.rs

RalfJung · 2019-07-23T15:19:18Z

@bors r-

will look at the comments later

src/libstd/primitive_docs.rs

Co-Authored-By: gnzlbg <gnzlbg@users.noreply.github.com>

RalfJung · 2019-07-23T15:49:46Z

@gnzlbg

This compiles on stable Rust, so if the Rust language isn't ok with it then somebody should open a soundness bug (playground).

Somebody did: #28179.

RalfJung · 2019-07-23T15:52:30Z

@Centril please have a look at the changes; the one about references is a new sentence so I didn't feel comfortable just doing r=Centril.

gnzlbg · 2019-07-23T15:59:46Z

@RalfJung there is no symbol defined twice in those playground examples (note the #![no_main] attribute), also the issue here is Rust accepting the static mut - the version without the mut is ok, as niko shows in that thread.

RalfJung · 2019-07-23T16:05:13Z

That issue is about no_mangle being unsafe in general; defining a symbol twice is just one of many ways.

Also see #28179 (comment) (EDIT: I see you edited your post to mention that). And no that version is not okay, it runs arbitrary unsafe code without unsafe.

Centril · 2019-07-23T18:47:38Z

@Centril please have a look at the changes; the one about references is a new sentence so I didn't feel comfortable just doing r=Centril.

Thanks; still looks good :)

@bors r+ rollup

bors · 2019-07-23T18:47:39Z

📌 Commit 65cf10d has been approved by Centril

Improve some pointer-related documentation

@ghost

Rollup of 11 pull requests Successful merges: - #62261 (Take substs into account in `conservative_is_privately_uninhabited`) - #62528 (Add joining slices of slices with a slice separator, not just a single item) - #62738 (Remove uses of mem::uninitialized from std::sys::cloudabi) - #62784 (Add riscv32i-unknown-none-elf target) - #62808 (Revert "Disable stack probing for gnux32.") - #62814 (add support for hexagon-unknown-linux-musl) - #62822 (Improve some pointer-related documentation) - #62890 (Normalize use of backticks in compiler messages for libsyntax/*) - #62901 (cleanup: Remove `extern crate serialize as rustc_serialize`s) - #62905 (Normalize use of backticks in compiler messages for doc) - #62908 (normalize use of backticks for compiler messages in remaining modules) Failed merges: r? @ghost

Improve some pointer-related documentation

@ghost

Rollup of 13 pull requests Successful merges: - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file) - rust-lang#61890 (Fix some sanity checks) - rust-lang#62084 (allow clippy::unreadable_literal in unicode tables) - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`) - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item) - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro) - rust-lang#62801 (Remove support for -Zlower-128bit-ops) - rust-lang#62808 (Revert "Disable stack probing for gnux32.") - rust-lang#62822 (Improve some pointer-related documentation) - rust-lang#62904 (Disable d32 on armv6 hf targets) - rust-lang#62907 (Initialize the MSP430 AsmParser) - rust-lang#62921 (Add method disambiguation help for trait implementation) - rust-lang#62942 (Use match ergonomics in Condvar documentation) Failed merges: r? @ghost

Improve some pointer-related documentation

@ghost

Rollup of 15 pull requests Successful merges: - #60066 (Stabilize the type_name intrinsic in core::any) - #60938 (rustdoc: make #[doc(include)] relative to the containing file) - #61884 (Stablize Euclidean Modulo (feature euclidean_division)) - #61890 (Fix some sanity checks) - #62528 (Add joining slices of slices with a slice separator, not just a single item) - #62707 (Add tests for overlapping explicitly dropped locals in generators) - #62735 (Turn `#[global_allocator]` into a regular attribute macro) - #62822 (Improve some pointer-related documentation) - #62887 (Make the parser TokenStream more resilient after mismatched delimiter recovery) - #62921 (Add method disambiguation help for trait implementation) - #62930 (Add test for #51559) - #62942 (Use match ergonomics in Condvar documentation) - #62977 (Fix inconsistent highlight blocks.) - #62978 (Remove `cfg(bootstrap)` code for array implementations) - #62981 (Add note suggesting to borrow a String argument to find) Failed merges: - #62964 (clarify and unify some type test names) r? @ghost

RalfJung added 2 commits July 20, 2019 13:19

warn that raw pointers must be aligned when used, and that writes cau…

21b502b

…se drop

references must be aligned; also move up the warning that fn ptrs mus…

2e6b13a

…t be non-NULL

rust-highfive assigned sfackler Jul 20, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2019

Centril reviewed Jul 20, 2019

View reviewed changes

rust-highfive assigned Centril and unassigned sfackler Jul 20, 2019

RalfJung added 2 commits July 21, 2019 12:08

sync with nomicon: raw ptr must be non-dangling and aligned every tim…

f502bf7

…e it is dereferenced

apply feedback

4081222

Lokathor reviewed Jul 22, 2019

View reviewed changes

src/libstd/primitive_docs.rs Outdated Show resolved Hide resolved

weasle, weasle

a7b9246

account for non-drop-glue types

9196781

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2019

Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019

Rollup merge of rust-lang#62822 - RalfJung:pointers, r=Centril

1d5ea88

Improve some pointer-related documentation

Centril mentioned this pull request Jul 22, 2019

Rollup of 12 pull requests #62882

Closed

gnzlbg reviewed Jul 23, 2019

View reviewed changes

src/libstd/primitive_docs.rs Outdated Show resolved Hide resolved

src/libstd/primitive_docs.rs Outdated Show resolved Hide resolved

src/libstd/primitive_docs.rs Show resolved Hide resolved

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2019

RalfJung commented Jul 23, 2019

View reviewed changes

src/libstd/primitive_docs.rs Outdated Show resolved Hide resolved

Apply suggestions from code review

dd5045e

Co-Authored-By: gnzlbg <gnzlbg@users.noreply.github.com>

word things more like we usually do

65cf10d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 23, 2019

Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019

Rollup merge of rust-lang#62822 - RalfJung:pointers, r=Centril

b71e579

Improve some pointer-related documentation

Centril mentioned this pull request Jul 24, 2019

Rollup of 11 pull requests #62923

Closed

RalfJung mentioned this pull request Jul 24, 2019

Validity of function pointers rust-lang/unsafe-code-guidelines#72

Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019

Rollup merge of rust-lang#62822 - RalfJung:pointers, r=Centril

a6a0122

Improve some pointer-related documentation

Centril mentioned this pull request Jul 24, 2019

Rollup of 13 pull requests #62960

Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 25, 2019

Rollup merge of rust-lang#62822 - RalfJung:pointers, r=Centril

8bc8562

Improve some pointer-related documentation

Centril mentioned this pull request Jul 25, 2019

Rollup of 9 pull requests #62966

Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 25, 2019

Rollup merge of rust-lang#62822 - RalfJung:pointers, r=Centril

a534c37

Improve some pointer-related documentation

Centril mentioned this pull request Jul 25, 2019

Rollup of 15 pull requests #62990

Merged

bors merged commit 65cf10d into rust-lang:master Jul 26, 2019

RalfJung deleted the pointers branch July 29, 2019 08:02

Improve some pointer-related documentation #62822

Improve some pointer-related documentation #62822

Uh oh!

Conversation

RalfJung commented Jul 20, 2019

Uh oh!

rust-highfive commented Jul 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centril commented Jul 20, 2019

Uh oh!

Uh oh!

Centril commented Jul 22, 2019

Uh oh!

Centril commented Jul 22, 2019

Uh oh!

bors commented Jul 22, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Jul 23, 2019

Uh oh!

Uh oh!

RalfJung commented Jul 23, 2019

Uh oh!

RalfJung commented Jul 23, 2019

Uh oh!

gnzlbg commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfJung commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centril commented Jul 23, 2019

Uh oh!

bors commented Jul 23, 2019

Uh oh!

Uh oh!

gnzlbg commented Jul 23, 2019 •

edited

Loading

RalfJung commented Jul 23, 2019 •

edited

Loading