Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ICE when suggestion span is at Eof #62995

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Avoid ICE when suggestion span is at Eof #62995

merged 2 commits into from
Jul 29, 2019

Conversation

estebank
Copy link
Contributor

Fix #62973.

@rust-highfive
Copy link
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2019
@estebank
Copy link
Contributor Author

Fun:

tidy error: /checkout/src/test/ui/parser/issue-62973.rs: too many trailing newlines (3)
tidy error: /checkout/src/test/ui/parser/issue-62973.rs: ignoring trailing whitespace unnecessarily

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the issue-62973 branch 2 times, most recently from 49754fc to b2aa095 Compare July 26, 2019 01:31
@rust-highfive

This comment has been minimized.

Sign in to view
@dwrensha
Copy link
Contributor

For what it's worth, here is a way to trigger the bug with fewer trailing newlines: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4cce30e8d42e50ab4eb2a3efe1b2c5b0

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@varkor
Copy link
Member

varkor commented Jul 28, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 28, 2019

📌 Commit 6263eb4 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019
@Centril
Rollup merge of rust-lang#62995 - estebank:issue-62973, r=varkor
a3cae57 
Avoid ICE when suggestion span is at Eof

Fix rust-lang#62973.
@Centril Centril mentioned this pull request Jul 28, 2019
Merged
bors added a commit that referenced this pull request Jul 28, 2019
@bors
Auto merge of #63090 - Centril:rollup-xnjwm2h, r=Centril
c7312fe 
Rollup of 8 pull requests

Successful merges:

 - #61856 (Lint attributes on function arguments)
 - #62360 (Document that ManuallyDrop::drop should not called more than once)
 - #62392 (Update minifier-rs version)
 - #62871 (Explicit error message for async recursion.)
 - #62995 (Avoid ICE when suggestion span is at Eof)
 - #63053 (SystemTime docs: recommend Instant for elapsed time)
 - #63081 (tidy: Cleanup the directory whitelist)
 - #63088 (Remove anonymous_parameters from unrelated test)

Failed merges:

r? @ghost
@bors bors merged commit 6263eb4 into rust-lang:master Jul 29, 2019
@estebank estebank deleted the issue-62973 branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE on "byte index 1 is out of bounds of ``"
5 participants
@estebank @rust-highfive @dwrensha @varkor @bors