Add lib section to rustc_lexer's Cargo.toml #63036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This was referenced Jul 27, 2019
matklad
reviewed
Jul 27, 2019
|
|
||
| [lib] | ||
| doctest = false | ||
| name = "rustc_lexer" |
There was a problem hiding this comment.
Could you add a comment explaining that we need this "no-op" lib section for purely for ap?
There was a problem hiding this comment.
Added a comment in 98f29f5.
|
r? @matklad r=me with an explanatory comment |
|
@bors r=matklad p=2 (blocks RLS update and Rustfmt/Racer nightly builds) |
|
📌 Commit 98f29f5 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 98f29f5 with merge 0ee6ce723198fcd11d708cb987beaf39e11d1cd5... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 27, 2019
Add lib section to rustc_lexer's Cargo.toml This is required to fix the rustc-ap-syntax build error in the recent version. The error could also be fixed on the [rustc-auto-publish](https://github.com/alexcrichton/rustc-auto-publish) side by manually adding `[lib]` section if one does not exist. The latter approach, however, may have a surprising side effect, so I am opting for a simpler solution for now. r? @alexcrichton
|
@bors retry rolled up |
bors
added a commit
that referenced
this pull request
Jul 27, 2019
Rollup of 6 pull requests Successful merges: - #62423 (Fix cycle error with existential types) - #62979 (Cleanup save-analysis JsonDumper) - #62982 (Don't access a static just for its size and alignment) - #63013 (add `repr(transparent)` to `IoSliceMut` where missing) - #63014 (Stop bare trait lint applying to macro call sites) - #63036 (Add lib section to rustc_lexer's Cargo.toml) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to fix the rustc-ap-syntax build error in the recent version. The error could also be fixed on the rustc-auto-publish side by manually adding
[lib]section if one does not exist. The latter approach, however, may have a surprising side effect, so I am opting for a simpler solution for now.r? @alexcrichton