-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make #![feature(bind_by_move_pattern_guards)]
sound without #[feature(nll)]
#63059
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good, but I wasn't expecting all matches with guards to result in hard borrowck errors. I'm not sure if @rust-lang/lang has an opinion here.
Fwiw, I tried some hacks to avoid it but that went nowhere... =) |
@bors r+ |
📌 Commit cd79609 has been approved by |
…ewjasper Make `#![feature(bind_by_move_pattern_guards)]` sound without `#[feature(nll)]` Implements rust-lang#15287 (comment). Fixes rust-lang#31287 Fixes rust-lang#27282 r? @matthewjasper
…ewjasper Make `#![feature(bind_by_move_pattern_guards)]` sound without `#[feature(nll)]` Implements rust-lang#15287 (comment). Fixes rust-lang#31287 Fixes rust-lang#27282 r? @matthewjasper
This comment has been minimized.
This comment has been minimized.
cd79609
to
1538b2a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Same error again, but this time tested standalone and not in a rollup:
|
The Servo failure is probably caused by servo/servo#23256. The last Servo commit that didn't use lld is servo/servo@caac107, so bumping to that should work. cc @jdm |
Updated the servo ref to @bors r=matthewjasper |
📌 Commit b289f6f has been approved by |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Make `#![feature(bind_by_move_pattern_guards)]` sound without `#[feature(nll)]` Implements #15287 (comment) making `#![feature(bind_by_move_pattern_guards)]]` sound without also having `#![feature(nll)]`. The logic here is that if we see a `match` guard, we will refuse to downgrade NLL errors to warnings. This is in preparation for hopefully stabilizing the former feature in #63118. As fall out from the implementation we also: Fixes #31287 Fixes #27282 r? @matthewjasper
☀️ Test successful - checks-azure |
Implements #15287 (comment) making
#![feature(bind_by_move_pattern_guards)]]
sound without also having#![feature(nll)]
. The logic here is that if we see amatch
guard, we will refuse to downgrade NLL errors to warnings. This is in preparation for hopefully stabilizing the former feature in #63118.As fall out from the implementation we also:
Fixes #31287
Fixes #27282
r? @matthewjasper