Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: implement argsfiles for command line #63175

Merged
merged 3 commits into from
Aug 22, 2019
Merged

rustc: implement argsfiles for command line #63175

merged 3 commits into from
Aug 22, 2019

Commits on Aug 20, 2019

  1. Use named arguments for formatting usage message. 

    It was getting a bit awkward.
    @jsgf
    jsgf committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    859657f View commit details
    Browse the repository at this point in the history

  2. rustc: implement argsfiles for command line 

    This makes `rustc` support `@path` arguments on the command line. The `path` is opened and the file is interpreted
as new command line options which are logically inserted at that point in the command-line. The options in the file
are one per line. The file is UTF-8 encoded, and may have either Unix or Windows line endings.
It does not support recursive use of `@path`.

This is useful for very large command lines, or when command-lines are being generated into files by other tooling.
    @jsgf
    jsgf committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    d2219c2 View commit details
    Browse the repository at this point in the history

  3. Move argfile expansion into run_compiler 

    This will make @path work with miri and other non-standard entrypoints.

Also since this simplifies librustc_driver::args, move it into a simple source file. Also
remove the tests since they're doing nothing more than checking `str::lines` has the right
behaviour.
    @jsgf
    jsgf committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    d949774 View commit details
    Browse the repository at this point in the history