Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: Remove rust_call_nullary_fn #6323

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/libcore/rt/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,35 @@ mod local_heap;
pub mod test;

pub fn start(main: *u8, _argc: int, _argv: **c_char, _crate_map: *u8) -> int {

use self::sched::{Scheduler, Task};
use self::uvio::UvEventLoop;
use sys::Closure;
use ptr;
use cast;

let loop_ = ~UvEventLoop::new();
let mut sched = ~Scheduler::new(loop_);

let main_task = ~do Task::new(&mut sched.stack_pool) {
// XXX: Can't call a C function pointer from Rust yet
unsafe { rust_call_nullary_fn(main) };

unsafe {
// `main` is an `fn() -> ()` that doesn't take an environment
// XXX: Could also call this as an `extern "Rust" fn` once they work
let main = Closure {
code: main as *(),
env: ptr::null(),
};
let mainfn: &fn() = cast::transmute(main);

mainfn();
}
};

sched.task_queue.push_back(main_task);
sched.run();
return 0;

extern {
fn rust_call_nullary_fn(f: *u8);
}
return 0;
}

/// Possible contexts in which Rust code may be executing.
Expand Down
7 changes: 0 additions & 7 deletions src/rt/rust_builtin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -830,13 +830,6 @@ rust_get_rt_env() {
return task->kernel->env;
}

typedef void *(*nullary_fn)();

extern "C" CDECL void
rust_call_nullary_fn(nullary_fn f) {
f();
}

#ifndef _WIN32
pthread_key_t sched_key;
#else
Expand Down
1 change: 0 additions & 1 deletion src/rt/rustrt.def.in
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ rust_uv_ip4_addrp
rust_uv_ip6_addrp
rust_uv_free_ip4_addr
rust_uv_free_ip6_addr
rust_call_nullary_fn
rust_initialize_global_state
rust_dbg_next_port
rust_new_memory_region
Expand Down