Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #63627

Merged
merged 42 commits into from
Aug 16, 2019
Merged

Rollup of 7 pull requests #63627

merged 42 commits into from
Aug 16, 2019

Commits on Aug 13, 2019

  1. Configuration menu
    Copy the full SHA
    0b713ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e019de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9805846 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    039c789 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    01e96dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0741441 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    88398a4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9287eb6 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. Configuration menu
    Copy the full SHA
    f54503c View commit details
    Browse the repository at this point in the history
  2. Grouping ABI test rust-lang#62401

    kper committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    f036fae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    98325eb View commit details
    Browse the repository at this point in the history
  4. Fixing broken tests rust-lang#62401

    The grouping led to a lot of `mv`. Therefore, some relative paths were
    wrong. In this commit the dependent files were also moved so that the paths
    work again.
    kper committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    cac53fe View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5941acd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    df713dd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a90d087 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4a8ff5b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    26ee99e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dfcbe75 View commit details
    Browse the repository at this point in the history
  11. syntax_pos: NO_EXPANSION/SyntaxContext::empty() -> `SyntaxContext…

    …::root()`
    
    For consistency with `ExpnId::root`.
    
    Also introduce a helper `Span::with_root_ctxt` for creating spans with `SyntaxContext::root()` context
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    67d6ce4 View commit details
    Browse the repository at this point in the history
  12. Ident::with_empty_ctxt -> Ident::with_dummy_span

    `Ident` has had a full span rather than just a `SyntaxContext` for a long time now.
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    6cb28b6 View commit details
    Browse the repository at this point in the history
  13. hygiene: Remove Options from functions returning ExpnInfo

    The expansion info is not optional and should always exist
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    73dee25 View commit details
    Browse the repository at this point in the history
  14. resolve: Move macro resolution traces from Modules to Resolver

    Traces already contain module info without that.
    It's easy to forget to call `finalize_*` on a module.
    In particular, macros enum and trait modules weren't finalized.
    By happy accident macros weren't placed into those modules until now.
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    23b82c3 View commit details
    Browse the repository at this point in the history
  15. resolve: Do not "normalize away" trait/enum modules prematurely

    The previous approach was brittle - what would happen if `ParentScope` wasn't created by `invoc_parent_scope`?
    That's exactly the case for various uses of `ParentScope` in diagnostics and in built-in attribute validation.
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    cfbb60b View commit details
    Browse the repository at this point in the history
  16. resolve: Add ParentScope::default, eliminate dummy_parent_scope

    Remove some unnecessary parameters from functions
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    1a1557c View commit details
    Browse the repository at this point in the history
  17. resolve: Eliminate InvocationData

    It was very similar to `ParentScope` and mostly could be replaced by it.
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    59dd07a View commit details
    Browse the repository at this point in the history
  18. resolve: Make ParentScope Copy

    By allocating its derive paths on the resolver arena.
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    ea68bc8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    310ee4d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    aca1353 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    1a44773 View commit details
    Browse the repository at this point in the history
  22. syntax_pos: Remove the duplicate global edition

    It was introduced to avoid going through `hygiene_data`, but now it's read only once, when `ParseSess` is created, so going through a lock is ok.
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    74190a5 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    650f19a View commit details
    Browse the repository at this point in the history
  24. hygiene: ExpnInfo -> ExpnData

    For naming consistency with everything else in this area
    petrochenkov committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    136db22 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    c762773 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    fbf1efb View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    e046a7a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. Rollup merge of rust-lang#62593 - kper:cleanup_abi, r=Centril

    Group all ABI tests.
    
    r? @eddyb
    
    Closes rust-lang#62401
    Centril authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    100a02a View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#63173 - malbarbo:musl-libunwind, r=alexcric…

    …hton
    
    Use libunwind from llvm-project submodule for musl targets
    
    This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
    Centril authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    32c1005 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#63535 - petrochenkov:expndata, r=matthewjasper

    Continue refactoring resolve and hygiene
    
    The general goal is addressing FIXMEs from the previous PRs.
    
    Merging similar data structures (+ prerequisites for such merging), accounting for the fact that all `ExpnId`s have associated data in `HygieneData` now (less `Option`s).
    
    Also, some renaming.
    This should be the last renaming session in this area, I think.
    
    r? @matthewjasper
    Centril authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    6e9e6ea View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#63539 - Centril:2015.await, r=oli-obk

    Suggest Rust 2018 on `<expr>.await` with no such field
    
    When type checking a field projection (`fn check_field`) to `<expr>.await` where `<expr>: τ` and `τ` is not a primitive type, suggest switching to Rust 2018. E.g.
    
    ```
    error[E0609]: no field `await` on type `std::pin::Pin<&mut dyn std::future::Future<Output = ()>>`
      --> $DIR/suggest-switching-edition-on-await.rs:31:7
       |
    LL |     x.await;
       |       ^^^^^ unknown field
       |
       = note: to `.await` a `Future`, switch to Rust 2018
       = help: set `edition = "2018"` in `Cargo.toml`
       = note: for more on editions, read https://doc.rust-lang.org/edition-guide
    ```
    
    Fixes rust-lang#63533
    
    This PR also performs some preparatory cleanups in `fn check_field`; the last 2 commits are where the suggestion is introduced and tested respectively.
    
    r? @varkor
    Centril authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    d9a429a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#63584 - Centril:cleanup-core-with-more-atb,…

    … r=alexreg
    
    libcore: more cleanups using `#![feature(associated_type_bounds)]`
    
    Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged.
    
    Closes rust-lang#63393
    
    r? @alexreg
    cc @iluuu1994
    cc rust-lang#52662
    Centril authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    7dbd98f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#63612 - estebank:macro-sugg-try-into, r=Cen…

    …tril
    
    Do not suggest `try_into` for base types inside of macro expansions
    Centril authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    8958e50 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#63615 - jens1o:patch-1, r=jonas-schievink

    Fix typo in DoubleEndedIterator::nth_back doc
    Centril authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    0bd3a85 View commit details
    Browse the repository at this point in the history