-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installed compiler dependencies #63630
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The bump only happened for LLVM 10 (while we're on LLVM 9), so technically we still support older compiler versions at this point in time. |
but to get it to work you need to set the allow-old-toolchain in the config.toml for llvm to receive LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN shall we add that to the description then? |
Ping from triage - Thank you. |
maybe I shall point to the https://reviews.llvm.org/D57264 that is in the llvm version used and due to that commit there is an compile error if the LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN option is not set and as that is not described in the readme I think update the compiler version is a good solution when llvm 10 also removes that possibility anyway. |
I think it makes sense to list the more modern dependencies as the default, and perhaps add a "subbullet" or something saying "you can use the older versions if you set LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN". (IIUC, that env variable is needed to use the older versions?) |
cbf828e
to
55c8e13
Compare
added a description in new chapter "Building rustc with older host toolchains" |
Ping from triage - Thank you. |
there is a soft-error for older toolchains from https://reviews.llvm.org/D57264 in preparation for the hard error in https://reviews.llvm.org/D66188
55c8e13
to
166719a
Compare
update the text according to the comments but also removed the range of compilers that was listed before due to the higher version listed did not need the option to be set |
📌 Commit 166719a has been approved by |
Update installed compiler dependencies As llvm have updated the minimum toolchain https://reviews.llvm.org/D66188
Update installed compiler dependencies As llvm have updated the minimum toolchain https://reviews.llvm.org/D66188
Update installed compiler dependencies As llvm have updated the minimum toolchain https://reviews.llvm.org/D66188
Rollup of 5 pull requests Successful merges: - #63630 (Update installed compiler dependencies) - #64536 (Update Cargo) - #64554 (Polonius: more `ui` test suite fixes) - #64566 (A more generic interface for dataflow analysis) - #64591 (Fix a minor grammar nit, update UI tests) Failed merges: r? @ghost
As llvm have updated the minimum toolchain
https://reviews.llvm.org/D66188