-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: general cleanup #63639
Merged
Merged
rustdoc: general cleanup #63639
Commits on Aug 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a77247a - Browse repository at this point
Copy the full SHA a77247aView commit details -
Move top-level Clean impl to function
This allows us to pass it a `&mut DocContext` which will allow removal of RefCells, etc. in the following commits. It's also somewhat a unique Clean impl in that it previously ignored `self` (re-retriveing hir::Crate), which it no longer needs to do.
Configuration menu - View commit details
-
Copy full SHA for e2b6f4c - Browse repository at this point
Copy the full SHA e2b6f4cView commit details -
Mutate DocContext from LibEmbargoVisitor and RustdocVisitor
We have &mut access, so remove the RefCell borrowing
Configuration menu - View commit details
-
Copy full SHA for 57d57c6 - Browse repository at this point
Copy the full SHA 57d57c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f5698 - Browse repository at this point
Copy the full SHA 95f5698View commit details -
Remove support for printing HRef in alternate mode
The alternate mode merely prints out the passed in text which is largely useless (as the text can simply be directly printed).
Configuration menu - View commit details
-
Copy full SHA for 0e079c2 - Browse repository at this point
Copy the full SHA 0e079c2View commit details -
Previously we stored the entire current path which is a bit expensive and only ever accessed its length. This stores the length directly.
Configuration menu - View commit details
-
Copy full SHA for 3307929 - Browse repository at this point
Copy the full SHA 3307929View commit details -
Configuration menu - View commit details
-
Copy full SHA for dafdfee - Browse repository at this point
Copy the full SHA dafdfeeView commit details
Commits on Aug 27, 2019
-
Transition a few fmt::Display impls to functions
This introduces a WithFormatter abstraction that permits one-time fmt::Display on an arbitrary closure, created via `display_fn`. This allows us to prevent allocation while still using functions instead of structs, which are a bit unwieldy to thread arguments through as they can't easily call each other (and are generally a bit opaque). The eventual goal here is likely to move us off of the formatting infrastructure entirely in favor of something more structured, but this is a good step to move us in that direction as it makes, for example, passing a context describing current state to the formatting impl much easier.
Configuration menu - View commit details
-
Copy full SHA for edfd555 - Browse repository at this point
Copy the full SHA edfd555View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3f0175 - Browse repository at this point
Copy the full SHA b3f0175View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0fab96 - Browse repository at this point
Copy the full SHA b0fab96View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.