Improve diagnostics: break/continue in wrong context #63780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Aug 21, 2019
GuillaumeGomez
approved these changes
Aug 21, 2019
|
@bors r+ rollup |
|
📌 Commit 600a64b has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 21, 2019
Improve diagnostics: break/continue in wrong context - Fix rust-lang#63712 - Use `` `break` `` or `` `continue` `` instead of always `break` in `cannot _...` - Show the enclosing closure or async block we're talking about - `` `break` outside of loop `` -> `` `break` outside of a loop `` for consistency r? @estebank
bors
added a commit
that referenced
this pull request
Aug 21, 2019
Rollup of 6 pull requests Successful merges: - #61236 (take into account the system theme) - #63717 (Fix nested eager expansions in arguments of `format_args`) - #63747 (update Miri) - #63772 (ci: move libc mirrors to the rust-lang-ci-mirrors bucket) - #63780 (Improve diagnostics: break/continue in wrong context) - #63781 (Run Clippy without json-rendered flag) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct_span_errcalls #63712`break`or`continue`instead of alwaysbreakincannot _...`break` outside of loop->`break` outside of a loopfor consistencyr? @estebank