Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #63797. Change &str -> String in docs. #63865

Closed
wants to merge 1 commit into from

Conversation

sam09
Copy link
Contributor

@sam09 sam09 commented Aug 24, 2019

Change occurences of &str to String in src/liballoc/string.rs. Fixes #63797.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2019
@sfackler
Copy link
Member

You'll need to add the [String] link down at the end of the doc block: https://github.com/rust-lang/rust/pull/63865/files#diff-b20377b91804731171923c04add0add0L482

@sam09
Copy link
Contributor Author

sam09 commented Aug 25, 2019

@sfackler Done. Please have look.

src/liballoc/string.rs Outdated Show resolved Hide resolved
@sam09 sam09 force-pushed the master branch 2 times, most recently from 3111d22 to dadf4b8 Compare August 28, 2019 16:40
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-28T16:40:52.5525111Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-28T16:40:52.5715396Z ##[command]git config gc.auto 0
2019-08-28T16:40:52.5787278Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-28T16:40:52.5846461Z ##[command]git config --get-all http.proxy
2019-08-28T16:40:52.6021667Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63865/merge:refs/remotes/pull/63865/merge
---
2019-08-28T17:44:29.5760419Z .................................................................................................... 1500/8969
2019-08-28T17:44:35.3830404Z .................................................................................................... 1600/8969
2019-08-28T17:44:48.3196975Z .............................................i...............i...................................... 1700/8969
2019-08-28T17:44:56.5276988Z .................................................................................................... 1800/8969
2019-08-28T17:45:11.0008546Z ....................................iiiii........................................................... 1900/8969
2019-08-28T17:45:21.8022628Z .................................................................................................... 2100/8969
2019-08-28T17:45:24.4244351Z .................................................................................................... 2200/8969
2019-08-28T17:45:28.8214036Z .................................................................................................... 2300/8969
2019-08-28T17:45:36.2110044Z .................................................................................................... 2400/8969
---
2019-08-28T17:48:36.9246687Z .......................i...............i............................................................ 4700/8969
2019-08-28T17:48:48.9350142Z .................................................................................................... 4800/8969
2019-08-28T17:48:55.2569322Z .................................................................................................... 4900/8969
2019-08-28T17:49:06.4514159Z .................................................................................................... 5000/8969
2019-08-28T17:49:11.8367066Z ....ii.ii........................................................................................... 5100/8969
2019-08-28T17:49:26.0019750Z .................................................................................................... 5300/8969
2019-08-28T17:49:33.3573056Z ...................................................................i................................ 5400/8969
2019-08-28T17:49:40.7784263Z .................................................................................................... 5500/8969
2019-08-28T17:49:47.8187565Z .................................................................................................... 5600/8969
2019-08-28T17:49:47.8187565Z .................................................................................................... 5600/8969
2019-08-28T17:49:58.3002188Z .............................................................ii...i..ii............i................ 5700/8969
2019-08-28T17:50:24.6546875Z .................................................................................................... 5900/8969
2019-08-28T17:50:33.3120334Z .................................................................................................... 6000/8969
2019-08-28T17:50:33.3120334Z .................................................................................................... 6000/8969
2019-08-28T17:50:40.0788595Z ..............................................................i..ii................................. 6100/8969
2019-08-28T17:51:08.5883096Z .................................................................................................... 6300/8969
2019-08-28T17:51:11.2923020Z .................i.................................................................................. 6400/8969
2019-08-28T17:51:12.8996772Z .........................................................................................i.......... 6500/8969
2019-08-28T17:51:15.6452749Z .................................................................................................... 6600/8969
---
2019-08-28T17:55:59.0418153Z  finished in 20.874
2019-08-28T17:55:59.0609935Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T17:55:59.2229796Z 
2019-08-28T17:55:59.2230842Z running 149 tests
2019-08-28T17:56:02.5244563Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/149
2019-08-28T17:56:04.5414698Z ..iiii..............i.........iii.i......ii......
2019-08-28T17:56:04.5416414Z 
2019-08-28T17:56:04.5418311Z  finished in 5.480
2019-08-28T17:56:04.5604037Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T17:56:04.7229760Z 
---
2019-08-28T17:56:06.8174750Z  finished in 2.257
2019-08-28T17:56:06.8350061Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T17:56:06.9878425Z 
2019-08-28T17:56:06.9878553Z running 9 tests
2019-08-28T17:56:06.9880210Z iiiiiiiii
2019-08-28T17:56:06.9880650Z 
2019-08-28T17:56:06.9881136Z  finished in 0.153
2019-08-28T17:56:07.0079729Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T17:56:07.1894996Z 
---
2019-08-28T17:56:25.4745727Z  finished in 18.466
2019-08-28T17:56:25.4935802Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T17:56:25.6557042Z 
2019-08-28T17:56:25.6557309Z running 122 tests
2019-08-28T17:56:50.1763688Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-28T17:56:54.9838467Z .i.i......iii.i.....ii
2019-08-28T17:56:54.9840939Z 
2019-08-28T17:56:54.9842735Z  finished in 29.490
2019-08-28T17:56:54.9849318Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T17:56:54.9850058Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-28T18:11:12.9189293Z 
2019-08-28T18:11:12.9191068Z    Doc-tests core
2019-08-28T18:11:18.3202721Z 
2019-08-28T18:11:18.3210583Z running 2379 tests
2019-08-28T18:11:31.0389497Z ......iiiii......................................................................................... 100/2379
2019-08-28T18:11:43.7369636Z .........................................................................ii......................... 200/2379
2019-08-28T18:12:13.7044291Z .................................................................................................... 400/2379
2019-08-28T18:12:13.7044291Z .................................................................................................... 400/2379
2019-08-28T18:12:25.2287399Z ..............................i..i.................iiii............................................. 500/2379
2019-08-28T18:12:49.1431990Z .................................................................................................... 700/2379
2019-08-28T18:13:01.4939989Z .................................................................................................... 800/2379
2019-08-28T18:13:13.7779182Z .................................................................................................... 900/2379
2019-08-28T18:13:25.9683306Z .................................................................................................... 1000/2379
---
2019-08-28T18:18:44.5337830Z ............................................... 300/763
2019-08-28T18:18:44.5358387Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-08-28T18:18:44.5788993Z .................................................................................................... 400/763
2019-08-28T18:18:46.6566810Z .................................................................................................... 500/763
2019-08-28T18:18:46.6821867Z ....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T18:18:46.6843582Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-08-28T18:18:46.6848642Z 1084:5.
2019-08-28T18:18:46.6883086Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T18:18:46.9154638Z ..........................................thread '.<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T18:18:46.9182845Z ....thread 'thread '..<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T18:18:46.9200152Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T18:18:46.9281895Z ............... 600/763
2019-08-28T18:18:48.9767903Z ......................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-08-28T18:18:48.9769285Z ......thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
---
2019-08-28T18:18:58.4443747Z 
2019-08-28T18:18:58.4444090Z running 991 tests
2019-08-28T18:19:22.6820216Z i................................................................................................... 100/991
2019-08-28T18:19:36.0230405Z .................................................................................................... 200/991
2019-08-28T18:19:45.0277409Z .................iii......i......i...i......i....................................................... 300/991
2019-08-28T18:19:50.1740976Z .................................................................................................... 400/991
2019-08-28T18:19:58.2859537Z ..................................i..i.................................ii........................... 500/991
2019-08-28T18:20:13.3330403Z .................................................................................................... 700/991
2019-08-28T18:20:13.3330403Z .................................................................................................... 700/991
2019-08-28T18:20:21.8058318Z .................iiii............................................................................... 800/991
2019-08-28T18:20:36.9658401Z .................................................................................................... 900/991
2019-08-28T18:20:44.7739292Z .......................................iiii................................................
2019-08-28T18:20:44.7741557Z 
2019-08-28T18:20:44.7902241Z  finished in 257.272
2019-08-28T18:20:44.7920119Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T18:20:44.9904385Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-08-28T18:34:46.3220273Z     Checking core v0.0.0 (/checkout/src/libcore)
2019-08-28T18:35:07.3897006Z     Checking rustc-std-workspace-core v1.0.0 (/checkout/src/tools/rustc-std-workspace-core)
2019-08-28T18:35:07.4266183Z     Checking compiler_builtins v0.1.18
2019-08-28T18:35:08.6310845Z  Documenting alloc v0.0.0 (/checkout/src/liballoc)
2019-08-28T18:35:11.0709790Z error: `[into_bytes]` cannot be resolved, ignoring it...
2019-08-28T18:35:11.0710542Z     |
2019-08-28T18:35:11.0710542Z     |
2019-08-28T18:35:11.0710875Z 449 |     /// The inverse of this method is [`into_bytes`].
2019-08-28T18:35:11.0711556Z     |
2019-08-28T18:35:11.0711851Z note: lint level defined here
2019-08-28T18:35:11.0712137Z    --> src/liballoc/lib.rs:70:9
2019-08-28T18:35:11.0712376Z     |
2019-08-28T18:35:11.0712376Z     |
2019-08-28T18:35:11.0713151Z 70  | #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
2019-08-28T18:35:11.0714144Z     = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-08-28T18:35:11.0714221Z 
2019-08-28T18:35:11.1994484Z error: aborting due to previous error
2019-08-28T18:35:11.1994597Z 
2019-08-28T18:35:11.1994597Z 
2019-08-28T18:35:11.2216468Z error: Could not document `alloc`.
2019-08-28T18:35:11.2216566Z 
2019-08-28T18:35:11.2216615Z Caused by:
2019-08-28T18:35:11.2217985Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name alloc src/liballoc/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="compiler-builtins-c"' --color always --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --resource-suffix 1.39.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-e105c0b9266fe10f.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-db383e97964fb507.rmeta` (exit code: 1)
2019-08-28T18:35:11.2224984Z 
2019-08-28T18:35:11.2224984Z 
2019-08-28T18:35:11.2226086Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-Z" "unstable-options" "-p" "alloc" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--resource-suffix" "1.39.0" "--index-page" "/checkout/src/doc/index.md"
2019-08-28T18:35:11.2227032Z 
2019-08-28T18:35:11.2227271Z 
2019-08-28T18:35:11.2232482Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-28T18:35:11.2233110Z Build completed unsuccessfully in 1:46:58
2019-08-28T18:35:11.2233110Z Build completed unsuccessfully in 1:46:58
2019-08-28T18:35:11.2297907Z == clock drift check ==
2019-08-28T18:35:11.2309965Z   local time: Wed Aug 28 18:35:11 UTC 2019
2019-08-28T18:35:11.3248659Z   network time: Wed, 28 Aug 2019 18:35:11 GMT
2019-08-28T18:35:11.3254332Z == end clock drift check ==
2019-08-28T18:35:13.9520537Z ##[error]Bash exited with code '1'.
2019-08-28T18:35:13.9562287Z ##[section]Starting: Checkout
2019-08-28T18:35:13.9564464Z ==============================================================================
2019-08-28T18:35:13.9564529Z Task         : Get sources
2019-08-28T18:35:13.9564584Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-28T19:29:51.9235006Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-28T19:29:51.9403761Z ##[command]git config gc.auto 0
2019-08-28T19:29:51.9470753Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-28T19:29:51.9528247Z ##[command]git config --get-all http.proxy
2019-08-28T19:29:51.9670260Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63865/merge:refs/remotes/pull/63865/merge
---
2019-08-28T20:27:10.5854177Z .................................................................................................... 1500/8972
2019-08-28T20:27:15.5208694Z .................................................................................................... 1600/8972
2019-08-28T20:27:26.9227658Z ................................................i...............i................................... 1700/8972
2019-08-28T20:27:34.3292796Z .................................................................................................... 1800/8972
2019-08-28T20:27:46.9564610Z .......................................iiiii........................................................ 1900/8972
2019-08-28T20:27:56.4465228Z .................................................................................................... 2100/8972
2019-08-28T20:27:58.8681590Z .................................................................................................... 2200/8972
2019-08-28T20:28:02.1796831Z .................................................................................................... 2300/8972
2019-08-28T20:28:08.7906403Z .................................................................................................... 2400/8972
---
2019-08-28T20:30:47.4396866Z ..........................i...............i......................................................... 4700/8972
2019-08-28T20:30:57.9389370Z .................................................................................................... 4800/8972
2019-08-28T20:31:03.3505638Z .................................................................................................... 4900/8972
2019-08-28T20:31:12.9041039Z .................................................................................................... 5000/8972
2019-08-28T20:31:17.8729246Z .......ii.ii........................................................................................ 5100/8972
2019-08-28T20:31:29.3000232Z .................................................................................................... 5300/8972
2019-08-28T20:31:36.5164607Z ......................................................................i............................. 5400/8972
2019-08-28T20:31:42.9203042Z .................................................................................................... 5500/8972
2019-08-28T20:31:48.9978665Z .................................................................................................... 5600/8972
2019-08-28T20:31:48.9978665Z .................................................................................................... 5600/8972
2019-08-28T20:31:58.2391362Z ................................................................ii...i..ii...........i.............. 5700/8972
2019-08-28T20:32:20.9909491Z .................................................................................................... 5900/8972
2019-08-28T20:32:29.2309464Z .................................................................................................... 6000/8972
2019-08-28T20:32:29.2309464Z .................................................................................................... 6000/8972
2019-08-28T20:32:35.4370488Z .................................................................i..ii.............................. 6100/8972
2019-08-28T20:33:01.3419143Z .................................................................................................... 6300/8972
2019-08-28T20:33:03.1024754Z ....................i............................................................................... 6400/8972
2019-08-28T20:33:04.9230822Z ............................................................................................i....... 6500/8972
2019-08-28T20:33:07.3480822Z .................................................................................................... 6600/8972
---
2019-08-28T20:37:14.8994690Z  finished in 17.333
2019-08-28T20:37:14.9154396Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T20:37:15.0810630Z 
2019-08-28T20:37:15.0812530Z running 149 tests
2019-08-28T20:37:17.9012958Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/149
2019-08-28T20:37:19.6268856Z ..iiii..............i.........iii.i......ii......
2019-08-28T20:37:19.6269384Z 
2019-08-28T20:37:19.6273287Z  finished in 4.711
2019-08-28T20:37:19.6419791Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T20:37:19.7796868Z 
---
2019-08-28T20:37:21.6142604Z  finished in 1.972
2019-08-28T20:37:21.6295825Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T20:37:21.7662114Z 
2019-08-28T20:37:21.7662250Z running 9 tests
2019-08-28T20:37:21.7662987Z iiiiiiiii
2019-08-28T20:37:21.7663285Z 
2019-08-28T20:37:21.7667621Z  finished in 0.137
2019-08-28T20:37:21.7818558Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T20:37:21.9382264Z 
---
2019-08-28T20:37:37.9003456Z  finished in 16.118
2019-08-28T20:37:37.9193149Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T20:37:38.0760246Z 
2019-08-28T20:37:38.0760899Z running 122 tests
2019-08-28T20:37:58.9954459Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-28T20:38:03.0636244Z .i.i......iii.i.....ii
2019-08-28T20:38:03.0640378Z 
2019-08-28T20:38:03.0640943Z  finished in 25.144
2019-08-28T20:38:03.0648391Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T20:38:03.0648751Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-28T20:50:24.9331503Z 
2019-08-28T20:50:24.9333691Z    Doc-tests core
2019-08-28T20:50:29.4549990Z 
2019-08-28T20:50:29.4551169Z running 2379 tests
2019-08-28T20:50:40.7485913Z ......iiiii......................................................................................... 100/2379
2019-08-28T20:50:51.8647402Z .........................................................................ii......................... 200/2379
2019-08-28T20:51:18.3443923Z .................................................................................................... 400/2379
2019-08-28T20:51:18.3443923Z .................................................................................................... 400/2379
2019-08-28T20:51:28.5565190Z ..............................i..i.................iiii............................................. 500/2379
2019-08-28T20:51:49.9336547Z .................................................................................................... 700/2379
2019-08-28T20:52:00.7313293Z .................................................................................................... 800/2379
2019-08-28T20:52:11.4075551Z .................................................................................................... 900/2379
2019-08-28T20:52:22.1138833Z .................................................................................................... 1000/2379
---
2019-08-28T20:57:01.7975123Z ............................................... 300/763
2019-08-28T20:57:01.7990561Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-08-28T20:57:01.8760366Z .................................................................................................... 400/763
2019-08-28T20:57:03.9476497Z .................................................................................................... 500/763
2019-08-28T20:57:03.9704591Z ....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T20:57:03.9725097Z ....thread 'thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-08-28T20:57:03.9747569Z .<unnamed>' panicked at '.called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs.:1084..:..5thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T20:57:04.1431902Z .........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T20:57:04.1506961Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T20:57:04.1556350Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-28T20:57:04.1792728Z ................ 600/763
---
2019-08-28T20:57:15.4042094Z 
2019-08-28T20:57:15.4042333Z running 991 tests
2019-08-28T20:57:36.7946334Z i................................................................................................... 100/991
2019-08-28T20:57:48.8276049Z .................................................................................................... 200/991
2019-08-28T20:57:56.5250362Z .................iii......i......i...i......i....................................................... 300/991
2019-08-28T20:58:00.9705279Z .................................................................................................... 400/991
2019-08-28T20:58:08.0501659Z ..................................i..i.................................ii........................... 500/991
2019-08-28T20:58:20.9637901Z .................................................................................................... 700/991
2019-08-28T20:58:20.9637901Z .................................................................................................... 700/991
2019-08-28T20:58:28.4847940Z .................iiii............................................................................... 800/991
2019-08-28T20:58:41.7819796Z .................................................................................................... 900/991
2019-08-28T20:58:48.4847213Z .......................................iiii................................................
2019-08-28T20:58:48.4847418Z 
2019-08-28T20:58:48.5015070Z  finished in 223.243
2019-08-28T20:58:48.5030848Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-28T20:58:48.6705208Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-08-28T21:11:37.9680615Z     Checking core v0.0.0 (/checkout/src/libcore)
2019-08-28T21:11:58.3310728Z     Checking rustc-std-workspace-core v1.0.0 (/checkout/src/tools/rustc-std-workspace-core)
2019-08-28T21:11:58.3622107Z     Checking compiler_builtins v0.1.18
2019-08-28T21:11:59.5552497Z  Documenting alloc v0.0.0 (/checkout/src/liballoc)
2019-08-28T21:12:01.8812125Z error: `[into_bytes]` cannot be resolved, ignoring it...
2019-08-28T21:12:01.8813599Z     |
2019-08-28T21:12:01.8813599Z     |
2019-08-28T21:12:01.8814447Z 449 |     /// The inverse of this method is [`into_bytes`].
2019-08-28T21:12:01.8816004Z     |
2019-08-28T21:12:01.8816445Z note: lint level defined here
2019-08-28T21:12:01.8816913Z    --> src/liballoc/lib.rs:70:9
2019-08-28T21:12:01.8817324Z     |
2019-08-28T21:12:01.8817324Z     |
2019-08-28T21:12:01.8818121Z 70  | #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
2019-08-28T21:12:01.8819274Z     = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-08-28T21:12:01.8819480Z 
2019-08-28T21:12:02.0149263Z error: aborting due to previous error
2019-08-28T21:12:02.0149922Z 
2019-08-28T21:12:02.0149922Z 
2019-08-28T21:12:02.0381327Z error: Could not document `alloc`.
2019-08-28T21:12:02.0382582Z 
2019-08-28T21:12:02.0382762Z Caused by:
2019-08-28T21:12:02.0384177Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name alloc src/liballoc/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="compiler-builtins-c"' --color always --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --resource-suffix 1.39.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-e105c0b9266fe10f.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-db383e97964fb507.rmeta` (exit code: 1)
2019-08-28T21:12:02.0397015Z 
2019-08-28T21:12:02.0397015Z 
2019-08-28T21:12:02.0398273Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-Z" "unstable-options" "-p" "alloc" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--resource-suffix" "1.39.0" "--index-page" "/checkout/src/doc/index.md"
2019-08-28T21:12:02.0399169Z 
2019-08-28T21:12:02.0399318Z 
2019-08-28T21:12:02.0403712Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-28T21:12:02.0403965Z Build completed unsuccessfully in 1:35:23
2019-08-28T21:12:02.0403965Z Build completed unsuccessfully in 1:35:23
2019-08-28T21:12:02.0456144Z == clock drift check ==
2019-08-28T21:12:02.0470092Z   local time: Wed Aug 28 21:12:02 UTC 2019
2019-08-28T21:12:02.1335856Z   network time: Wed, 28 Aug 2019 21:12:02 GMT
2019-08-28T21:12:02.1340348Z == end clock drift check ==
2019-08-28T21:12:04.8066542Z ##[error]Bash exited with code '1'.
2019-08-28T21:12:04.8120046Z ##[section]Starting: Checkout
2019-08-28T21:12:04.8122345Z ==============================================================================
2019-08-28T21:12:04.8122420Z Task         : Get sources
2019-08-28T21:12:04.8122468Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@@ -480,7 +480,7 @@ impl String {
/// with this error.
///
/// [`from_utf8_unchecked`]: struct.String.html#method.from_utf8_unchecked
/// [`&str`]: ../../std/primitive.str.html
/// [`String`]: ../../std/string/struct.String.html
/// [`u8`]: ../../std/primitive.u8.html
/// [`Vec<u8>`]: ../../std/vec/struct.Vec.html
/// [`str::from_utf8`]: ../../std/str/fn.from_utf8.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urls here should point to String methods, not to str methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I am not sure what you are referring to here

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also modify this line to point into_bytes.

/// [`as_bytes`]: struct.String.html#method.as_bytes

Change occurences of &str to String in src/liballoc/string.rs
@bors bors closed this in a852ebb Sep 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 24, 2019
fix several issues in String docs

- In some places &str was shown instead of String.
- into_bytes is the reverse of from_utf8

Fixes rust-lang#63797

I've retaken the work done in this PR: rust-lang#63865 which for some reason was closed.
and just done a minor change (I hope you don't mind @sam09 ).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

&str->String in the docs
5 participants