Fixes #63797. Change &str -> String in docs. #63865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
You'll need to add the |
|
@sfackler Done. Please have look. |
matklad
reviewed
Aug 26, 2019
sam09
force-pushed
the
master
branch
2 times, most recently
from
3111d22 to
dadf4b8
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
matklad
reviewed
Aug 29, 2019
| @@ -480,7 +480,7 @@ impl String { | |||
| /// with this error. | |||
| /// | |||
| /// [`from_utf8_unchecked`]: struct.String.html#method.from_utf8_unchecked | |||
| /// [`&str`]: ../../std/primitive.str.html | |||
| /// [`String`]: ../../std/string/struct.String.html | |||
| /// [`u8`]: ../../std/primitive.u8.html | |||
| /// [`Vec<u8>`]: ../../std/vec/struct.Vec.html | |||
| /// [`str::from_utf8`]: ../../std/str/fn.from_utf8.html | |||
There was a problem hiding this comment.
Urls here should point to String methods, not to str methods
There was a problem hiding this comment.
Hey I am not sure what you are referring to here
JohnTitor
reviewed
Sep 2, 2019
There was a problem hiding this comment.
I think we should also modify this line to point into_bytes.
Line 487 in fdaf594
Change occurences of &str to String in src/liballoc/string.rs
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 24, 2019
fix several issues in String docs - In some places &str was shown instead of String. - into_bytes is the reverse of from_utf8 Fixes rust-lang#63797 I've retaken the work done in this PR: rust-lang#63865 which for some reason was closed. and just done a minor change (I hope you don't mind @sam09 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change occurences of &str to String in src/liballoc/string.rs. Fixes #63797.