Skip to content

Conversation

petrochenkov
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2019
@estebank
Copy link
Contributor

r=me if you don't want to wait for @Mark-Simulacrum to see this.

@petrochenkov
Copy link
Contributor Author

@bors r=estebank
(Tested locally.)

@bors
Copy link
Collaborator

bors commented Aug 25, 2019

📌 Commit 5b7df09 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2019
@estebank
Copy link
Contributor

r? @estebank

@bors
Copy link
Collaborator

bors commented Aug 26, 2019

⌛ Testing commit 5b7df09 with merge 9fa8f14...

bors added a commit that referenced this pull request Aug 26, 2019
pprust: Do not print spaces before some tokens

Fixes #63896

r? @Mark-Simulacrum
@bors
Copy link
Collaborator

bors commented Aug 26, 2019

☀️ Test successful - checks-azure
Approved by: estebank
Pushing 9fa8f14 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2019
@bors bors merged commit 5b7df09 into rust-lang:master Aug 26, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #63897!

Tested on commit 9fa8f14.
Direct link to PR: #63897

💔 rustc-guide on linux: test-pass → test-fail (cc @mark-i-m @spastorino @amanjeev, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 26, 2019
Tested on commit rust-lang/rust@9fa8f14.
Direct link to PR: <rust-lang/rust#63897>

💔 rustc-guide on linux: test-pass → test-fail (cc @mark-i-m @spastorino @amanjeev, @rust-lang/infra).
@petrochenkov petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 26, 2019
@pietroalbini pietroalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 29, 2019
@Centril Centril added I-nominated T-lang Relevant to the language team labels Sep 5, 2019
@Centril
Copy link
Contributor

Centril commented Sep 5, 2019

Nominating for the language team as a proxy for the more general issue of pretty printing stability.

@pnkfelix
Copy link
Contributor

discussed at T-compiler meeting. approved for beta-backport. (The T-lang tagging, AFAICT, is not part of the beta-backport nomination.)

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 12, 2019
bors added a commit that referenced this pull request Sep 14, 2019
[beta] Rollup backports

Cherry-picked:

- Permit unwinding through FFI by default #62603
- pprust: Do not print spaces before some tokens #63897
- Account for doc comments coming from proc macros without spans #63930
- Support "soft" feature-gating using a lint #64066
- Update xLTO compatibility table in rustc book. #64092
- Include compiler-rt in the source tarball #64240
- Update LLVM submodule #64317

r? @Mark-Simulacrum
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 14, 2019
@petrochenkov petrochenkov deleted the prettycomma branch February 22, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.38] Regression: proc-macro derive panicked
9 participants