Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout: Factor out a utility function. #63899

Closed
wants to merge 1 commit into from
Closed

layout: Factor out a utility function. #63899

wants to merge 1 commit into from

Conversation

hvenev
Copy link
Contributor

@hvenev hvenev commented Aug 25, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @zackmdavis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2019
@hvenev hvenev mentioned this pull request Aug 25, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Aug 25, 2019

cc @eddyb

@eddyb
Copy link
Member

eddyb commented Aug 26, 2019

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned zackmdavis Aug 26, 2019
eddyb
eddyb reviewed Aug 26, 2019
View reviewed changes
src/librustc/ty/layout.rs
@@ -267,24 +267,27 @@ impl<'tcx> LayoutCx<'tcx, TyCtxt<'tcx>> {
}
}

fn align_and_pack(&self, repr: &ReprOptions) -> (AbiAndPrefAlign, Option<Align>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you added a pack: Option<Align> field to ReprOptions?
The Align encoding is logarithmic so it would occupy less space and not need further conversion.

cc @oli-obk @nagisa @rkruppe (curious what other people think)

@bors
Copy link
Contributor

bors commented Aug 29, 2019

☔ The latest upstream changes (presumably #63998) made this pull request unmergeable. Please resolve the merge conflicts.

@wirelessringo
Copy link

Ping from triage. @hvenev any updates on this? Thanks.

@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2019
@JohnCSimon
Copy link
Member

Ping from triage.
@hvenev Can you please address the merge conflicts?
cc: @eddyb
thank you!

@JohnCSimon JohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Sep 20, 2019
@JohnCSimon
Copy link
Member

Ping from triage.
@hvenev Unfortunately this PR has sat idle for nearly a month and I'm going to have to close it.
cc: @eddyb
thanks for your contribution, and feel free to reopen this when you can address it again.

@JohnCSimon JohnCSimon closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb left review comments

Assignees

@eddyb eddyb

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hvenev @rust-highfive @Centril @eddyb @bors @wirelessringo @JohnCSimon @zackmdavis @rustbot