compiletest: disable -Aunused for run-pass tests #64078

Mark-Simulacrum · 2019-09-01T21:32:05Z

Disabled the flag, but that led to quite a bit of fall out -- I think most of it is benign but I've not investigated thoroughly.

r? @petrochenkov

Mark-Simulacrum · 2019-09-01T21:32:13Z

cc #43896

Centril · 2019-09-01T21:35:00Z

Please use #![allow(...)]s per test instead at least so we can get rid of the noise here.

Mark-Simulacrum · 2019-09-01T21:55:03Z

If we're just going to re-add all the tests to have allow then there's probably no point in doing this, I was just posting this so I didn't forget and for some review on the output. I personally am not sure this is the right approach anymore, as this seems fairly noisy as you said and has a lot of false positives...

Centril · 2019-09-01T21:58:02Z

It's not that many tests really. As for triaging them, I know that at least the warnings in the ATB tests can be safely ignored since I wrote all of those tests.

Mark-Simulacrum · 2019-09-01T22:02:04Z

Not sure I follow you, but I'm not particularly against adding #![allow(unused)] to tests where we've triaged them or have prior knowledge of it being fine -- e.g., ATB tests, as you've noted -- I'm just against landing this by re-enabling all run-pass tests as allow(unused) without review.

petrochenkov · 2019-09-01T22:04:21Z

So, my idea was that if a run-pass test has dead code, then it's either

not a run-pass test, but rather a compile-pass test and should be marked as such, or
something suspicious is happening and some code intended to run doesn't run.

So, I expected doing triage rather than adding allows or just leaving the *.stderr files.
allows can be added with "TRIAGE ME" comments though, so it could be triaged later.

Centril · 2019-09-01T22:09:13Z

@Mark-Simulacrum Oh ofc we should do triage and not stick allow there blindly. But I think that should be fairly easy to do for these tests; they are not that many.

Mark-Simulacrum · 2019-09-01T22:20:06Z

I'll add the allows for ATB tests next session I have for impl work; happy to go either route for the rest of the tests.

rust-highfive · 2019-09-01T23:22:06Z

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-01T21:32:38.5570687Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-01T21:32:39.2193758Z ##[command]git config gc.auto 0
2019-09-01T21:32:39.2198293Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-01T21:32:39.2202023Z ##[command]git config --get-all http.proxy
2019-09-01T21:32:39.2208206Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64078/merge:refs/remotes/pull/64078/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RalfJung · 2019-09-02T14:03:58Z

So, my idea was that if a run-pass test has dead code, then it's either

not a run-pass test, but rather a compile-pass test and should be marked as such, or

something suspicious is happening and some code intended to run doesn't run.

Agreed. In fact, we are specifically working around this -A unued in Miri because we have had issues where tests had an accidental "unused X" warning that we missed because of this.

Mark-Simulacrum · 2019-09-02T19:24:26Z

Updated. A few tests are moved to check-pass since we don't need to actually run them to verify their results, and otherwise most have allows tagged on.

src/test/ui/associated-type-bounds/bounds-on-assoc-in-trait.rs

src/test/ui/async-await/argument-patterns.rs

src/test/ui/async-await/issues/issue-54752-async-block.rs

src/test/ui/borrowck/borrowck-migrate-to-nll.rs

src/test/ui/consts/const-labeled-break.rs

Mark-Simulacrum · 2019-09-02T21:52:08Z

Fixed review comments.

src/test/ui/async-await/multiple-lifetimes/hrtb.rs

src/test/ui/borrowck/borrowck-migrate-to-nll.rs

src/test/ui/const-generics/apit-with-const-param.rs

src/test/ui/const-generics/issue-61422.rs

src/test/ui/const-generics/unused-const-param.rs

src/test/ui/deprecation/deprecation-in-future.rs

src/test/ui/hrtb/issue-57639.rs

src/test/ui/impl-trait/closure-calling-parent-fn.rs

src/test/ui/issues/issue-61711-once-caused-rustc-inf-loop.rs

Mark-Simulacrum · 2019-09-03T15:25:57Z

Force-pushed fixes.

petrochenkov · 2019-09-03T15:57:32Z

@bors r+

bors · 2019-09-03T15:57:33Z

📌 Commit 09a442d has been approved by petrochenkov

Mark-Simulacrum · 2019-09-06T21:30:27Z

@bors r=petrochenkov

bors · 2019-09-06T21:30:28Z

📌 Commit b33890333b739db284aa527e583f957a5eddd51f has been approved by petrochenkov

rust-highfive · 2019-09-06T23:26:03Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-06T22:14:57.9917073Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-06T22:14:58.0118538Z ##[command]git config gc.auto 0
2019-09-06T22:14:58.0189882Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-06T22:14:58.0250582Z ##[command]git config --get-all http.proxy
2019-09-06T22:14:58.0409300Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64078/merge:refs/remotes/pull/64078/merge
---
2019-09-06T23:15:21.8113942Z .................................................................................................... 1500/9004
2019-09-06T23:15:27.4766846Z .................................................................................................... 1600/9004
2019-09-06T23:15:39.7775280Z ......................................................i...............i............................. 1700/9004
2019-09-06T23:15:47.2776475Z .................................................................................................... 1800/9004
2019-09-06T23:16:01.0881228Z .............................................iiiii.................................................. 1900/9004
2019-09-06T23:16:11.6212322Z .................................................................................................... 2100/9004
2019-09-06T23:16:14.0719972Z .................................................................................................... 2200/9004
2019-09-06T23:16:17.6020548Z .................................................................................................... 2300/9004
2019-09-06T23:16:25.3207941Z .................................................................................................... 2400/9004
---
2019-09-06T23:19:16.5960711Z .................................i...............i.................................................. 4700/9004
2019-09-06T23:19:27.8495268Z .................................................................................................... 4800/9004
2019-09-06T23:19:33.9290823Z .................................................................................................... 4900/9004
2019-09-06T23:19:44.1960948Z .................................................................................................... 5000/9004
2019-09-06T23:19:49.8757671Z ...............ii.ii................................................................................ 5100/9004
2019-09-06T23:20:00.1519921Z .................................................................................................... 5300/9004
2019-09-06T23:20:09.8367602Z ..............................................................................i..................... 5400/9004
2019-09-06T23:20:17.1892257Z .................................................................................................... 5500/9004
2019-09-06T23:20:23.0998366Z .................................................................................................... 5600/9004
2019-09-06T23:20:23.0998366Z .................................................................................................... 5600/9004
2019-09-06T23:20:33.3294616Z ........................................................................ii...i..ii...........i...... 5700/9004
2019-09-06T23:20:57.5090425Z .................................................................................................... 5900/9004
2019-09-06T23:21:06.9133603Z .................................................................................................... 6000/9004
2019-09-06T23:21:06.9133603Z .................................................................................................... 6000/9004
2019-09-06T23:21:13.1452869Z ..........................................................................i..ii..................... 6100/9004
2019-09-06T23:21:41.4509402Z .................................................................................................... 6300/9004
2019-09-06T23:21:43.4355802Z .................................i.................................................................. 6400/9004
2019-09-06T23:21:45.4692737Z .................................................................................................... 6500/9004
2019-09-06T23:21:47.9053277Z .....i.............................................................................................. 6600/9004
---
2019-09-06T23:25:41.7951490Z failures:
2019-09-06T23:25:41.7981765Z 
2019-09-06T23:25:41.7982564Z ---- [ui] ui/borrowck/borrowck-migrate-to-nll.rs#edition stdout ----
2019-09-06T23:25:41.7982754Z 
2019-09-06T23:25:41.7983121Z error in revision `edition`: test compilation failed although it shouldn't!
2019-09-06T23:25:41.7983304Z status: exit code: 1
2019-09-06T23:25:41.7984149Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/borrowck/borrowck-migrate-to-nll.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "edition" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.edition" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.edition/auxiliary" "-A" "unused"
2019-09-06T23:25:41.7985662Z ------------------------------------------
2019-09-06T23:25:41.7985852Z 
2019-09-06T23:25:41.7986213Z ------------------------------------------
2019-09-06T23:25:41.7986388Z stderr:
2019-09-06T23:25:41.7986388Z stderr:
2019-09-06T23:25:41.7986763Z ------------------------------------------
2019-09-06T23:25:41.7986955Z error[E0502]: cannot borrow `*block.current` as immutable because it is also borrowed as mutable
2019-09-06T23:25:41.7987550Z    |
2019-09-06T23:25:41.7987696Z LL |     let x = &mut block;
2019-09-06T23:25:41.7988686Z    |             ---------- mutable borrow occurs here
2019-09-06T23:25:41.7988686Z    |             ---------- mutable borrow occurs here
2019-09-06T23:25:41.7989107Z LL |     let p: &'a u8 = &*block.current;
2019-09-06T23:25:41.7989272Z    |                     ^^^^^^^^^^^^^^^ immutable borrow occurs here
2019-09-06T23:25:41.7989541Z LL |     drop(x);
2019-09-06T23:25:41.7989541Z LL |     drop(x);
2019-09-06T23:25:41.7989840Z    |          - mutable borrow later used here
2019-09-06T23:25:41.7990142Z error: aborting due to previous error
2019-09-06T23:25:41.7990246Z 
2019-09-06T23:25:41.7990572Z For more information about this error, try `rustc --explain E0502`.
2019-09-06T23:25:41.7990708Z 
---
2019-09-06T23:25:41.8019031Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-06T23:25:41.8019328Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-06T23:25:41.8036657Z 
2019-09-06T23:25:42.6558177Z 
2019-09-06T23:25:42.6566600Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-06T23:25:42.6567358Z 
2019-09-06T23:25:42.6567388Z 
2019-09-06T23:25:42.6567455Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-06T23:25:42.6567499Z Build completed unsuccessfully in 1:03:33
2019-09-06T23:25:42.6567499Z Build completed unsuccessfully in 1:03:33
2019-09-06T23:25:42.6568031Z == clock drift check ==
2019-09-06T23:25:42.6568100Z   local time: Fri Sep  6 23:25:41 UTC 2019
2019-09-06T23:25:42.6568154Z   network time: Fri, 06 Sep 2019 23:25:42 GMT
2019-09-06T23:25:42.6568275Z == end clock drift check ==
2019-09-06T23:25:42.8758891Z ##[error]Bash exited with code '1'.
2019-09-06T23:25:42.8797669Z ##[section]Starting: Checkout
2019-09-06T23:25:42.8799624Z ==============================================================================
2019-09-06T23:25:42.8799666Z Task         : Get sources
2019-09-06T23:25:42.8799702Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2019-09-07T00:20:33Z

@bors r-

Rebase error, misunderstood test results locally.

rust-highfive · 2019-09-08T00:42:00Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-07T23:30:39.5791128Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-07T23:30:39.5987913Z ##[command]git config gc.auto 0
2019-09-07T23:30:39.6053493Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-07T23:30:39.6108423Z ##[command]git config --get-all http.proxy
2019-09-07T23:30:39.6237889Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64078/merge:refs/remotes/pull/64078/merge
---
2019-09-08T00:30:18.4024545Z .................................................................................................... 1500/9006
2019-09-08T00:30:24.5504721Z .................................................................................................... 1600/9006
2019-09-08T00:30:38.0276079Z ......................................................i...............i............................. 1700/9006
2019-09-08T00:30:46.2555525Z .................................................................................................... 1800/9006
2019-09-08T00:31:01.6724598Z .............................................iiiii.................................................. 1900/9006
2019-09-08T00:31:13.4251994Z .................................................................................................... 2100/9006
2019-09-08T00:31:16.1350895Z .................................................................................................... 2200/9006
2019-09-08T00:31:19.9855589Z .................................................................................................... 2300/9006
2019-09-08T00:31:28.2837839Z .................................................................................................... 2400/9006
---
2019-09-08T00:34:35.0319768Z .................................i...............i.................................................. 4700/9006
2019-09-08T00:34:47.4201260Z .................................................................................................... 4800/9006
2019-09-08T00:34:53.9136928Z .................................................................................................... 4900/9006
2019-09-08T00:35:05.1283050Z .................................................................................................... 5000/9006
2019-09-08T00:35:11.4047499Z ...............ii.ii................................................................................ 5100/9006
2019-09-08T00:35:22.5898931Z .................................................................................................... 5300/9006
2019-09-08T00:35:33.0945384Z ..............................................................................i..................... 5400/9006
2019-09-08T00:35:41.0554356Z .................................................................................................... 5500/9006
2019-09-08T00:35:47.3948231Z .................................................................................................... 5600/9006
2019-09-08T00:35:47.3948231Z .................................................................................................... 5600/9006
2019-09-08T00:35:58.3651616Z ........................................................................ii...i..ii...........i...... 5700/9006
2019-09-08T00:36:24.7280792Z .................................................................................................... 5900/9006
2019-09-08T00:36:34.6186127Z .................................................................................................... 6000/9006
2019-09-08T00:36:34.6186127Z .................................................................................................... 6000/9006
2019-09-08T00:36:40.4043684Z ..........................................................................i..ii..................... 6100/9006
2019-09-08T00:37:10.8373884Z .................................................................................................... 6300/9006
2019-09-08T00:37:13.0466332Z .................................i.................................................................. 6400/9006
2019-09-08T00:37:15.3662274Z .................................................................................................... 6500/9006
2019-09-08T00:37:18.1243841Z .....i.............................................................................................. 6600/9006
---
2019-09-08T00:41:33.7726577Z 
2019-09-08T00:41:33.7728640Z ---- [ui] ui/borrowck/borrowck-migrate-to-nll.rs#edition stdout ----
2019-09-08T00:41:33.7729081Z diff of stderr:
2019-09-08T00:41:33.7729270Z 
2019-09-08T00:41:33.7729472Z 1 error[E0502]: cannot borrow `*block.current` as immutable because it is also borrowed as mutable
2019-09-08T00:41:33.7730853Z +   --> $DIR/borrowck-migrate-to-nll.rs:29:21
2019-09-08T00:41:33.7730944Z 3    |
2019-09-08T00:41:33.7730995Z 4 LL |     let x = &mut block;
2019-09-08T00:41:33.7731329Z 5    |             ---------- mutable borrow occurs here
2019-09-08T00:41:33.7731329Z 5    |             ---------- mutable borrow occurs here
2019-09-08T00:41:33.7731372Z 
2019-09-08T00:41:33.7731401Z 
2019-09-08T00:41:33.7731466Z The actual stderr differed from the expected stderr.
2019-09-08T00:41:33.7731838Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.edition/borrowck-migrate-to-nll.edition.stderr
2019-09-08T00:41:33.7732117Z To update references, rerun the tests and pass the `--bless` flag
2019-09-08T00:41:33.7732469Z To only update this specific test, also pass `--test-args borrowck/borrowck-migrate-to-nll.rs`
2019-09-08T00:41:33.7732507Z 
2019-09-08T00:41:33.7732553Z error in revision `edition`: 1 errors occurred comparing output.
2019-09-08T00:41:33.7732598Z status: exit code: 1
2019-09-08T00:41:33.7733897Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/borrowck/borrowck-migrate-to-nll.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "edition" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.edition" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.edition/auxiliary" "-A" "unused"
2019-09-08T00:41:33.7734662Z ------------------------------------------
2019-09-08T00:41:33.7734700Z 
2019-09-08T00:41:33.7734975Z ------------------------------------------
2019-09-08T00:41:33.7735025Z stderr:
2019-09-08T00:41:33.7735025Z stderr:
2019-09-08T00:41:33.7735264Z ------------------------------------------
2019-09-08T00:41:33.7735467Z error[E0502]: cannot borrow `*block.current` as immutable because it is also borrowed as mutable
2019-09-08T00:41:33.7735846Z    |
2019-09-08T00:41:33.7735910Z LL |     let x = &mut block;
2019-09-08T00:41:33.7736172Z    |             ---------- mutable borrow occurs here
2019-09-08T00:41:33.7736172Z    |             ---------- mutable borrow occurs here
2019-09-08T00:41:33.7736420Z LL |     let p: &'a u8 = &*block.current;
2019-09-08T00:41:33.7736493Z    |                     ^^^^^^^^^^^^^^^ immutable borrow occurs here
2019-09-08T00:41:33.7736582Z LL |     drop(x);
2019-09-08T00:41:33.7736582Z LL |     drop(x);
2019-09-08T00:41:33.7736834Z    |          - mutable borrow later used here
2019-09-08T00:41:33.7736944Z error: aborting due to previous error
2019-09-08T00:41:33.7736973Z 
2019-09-08T00:41:33.7737402Z For more information about this error, try `rustc --explain E0502`.
2019-09-08T00:41:33.7737457Z 
2019-09-08T00:41:33.7737457Z 
2019-09-08T00:41:33.7737694Z ------------------------------------------
2019-09-08T00:41:33.7737728Z 
2019-09-08T00:41:33.7737761Z 
2019-09-08T00:41:33.7738037Z ---- [ui] ui/borrowck/borrowck-migrate-to-nll.rs#zflag stdout ----
2019-09-08T00:41:33.7738072Z 
2019-09-08T00:41:33.7738116Z error in revision `zflag`: ui test compiled successfully!
2019-09-08T00:41:33.7738160Z status: exit code: 0
2019-09-08T00:41:33.7739010Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/borrowck/borrowck-migrate-to-nll.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "zflag" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.zflag" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "borrowck=migrate" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.zflag/auxiliary" "-A" "unused"
2019-09-08T00:41:33.7739380Z ------------------------------------------
2019-09-08T00:41:33.7739415Z 
2019-09-08T00:41:33.7739652Z ------------------------------------------
2019-09-08T00:41:33.7739716Z stderr:
2019-09-08T00:41:33.7739716Z stderr:
2019-09-08T00:41:33.7739945Z ------------------------------------------
2019-09-08T00:41:33.7740002Z warning[E0502]: cannot borrow `*block.current` as immutable because it is also borrowed as mutable
2019-09-08T00:41:33.7740341Z    |
2019-09-08T00:41:33.7740383Z LL |     let x = &mut block;
2019-09-08T00:41:33.7740652Z    |             ---------- mutable borrow occurs here
2019-09-08T00:41:33.7740652Z    |             ---------- mutable borrow occurs here
2019-09-08T00:41:33.7740903Z LL |     let p: &'a u8 = &*block.current;
2019-09-08T00:41:33.7740955Z    |                     ^^^^^^^^^^^^^^^ immutable borrow occurs here
2019-09-08T00:41:33.7741056Z LL |     drop(x);
2019-09-08T00:41:33.7741056Z LL |     drop(x);
2019-09-08T00:41:33.7741292Z    |          - mutable borrow later used here
2019-09-08T00:41:33.7741418Z    = warning: this error has been downgraded to a warning for backwards compatibility with previous releases
2019-09-08T00:41:33.7741480Z    = warning: this represents potential undefined behavior in your code and this warning will become a hard error in the future
2019-09-08T00:41:33.7741770Z    = note: for more information, try `rustc --explain E0729`
2019-09-08T00:41:33.7741808Z 
---
2019-09-08T00:41:33.7789053Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-08T00:41:33.7789186Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-08T00:41:33.7809434Z 
2019-09-08T00:41:33.7809548Z 
2019-09-08T00:41:33.7811540Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-08T00:41:33.7811834Z 
2019-09-08T00:41:33.7811865Z 
2019-09-08T00:41:33.7817522Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-08T00:41:33.7817806Z Build completed unsuccessfully in 1:04:04
2019-09-08T00:41:33.7817806Z Build completed unsuccessfully in 1:04:04
2019-09-08T00:41:33.7870790Z == clock drift check ==
2019-09-08T00:41:33.7885963Z   local time: Sun Sep  8 00:41:33 UTC 2019
2019-09-08T00:41:33.9407848Z   network time: Sun, 08 Sep 2019 00:41:33 GMT
2019-09-08T00:41:33.9408276Z == end clock drift check ==
2019-09-08T00:41:34.7188054Z ##[error]Bash exited with code '1'.
2019-09-08T00:41:34.7254546Z ##[section]Starting: Checkout
2019-09-08T00:41:34.7256619Z ==============================================================================
2019-09-08T00:41:34.7256670Z Task         : Get sources
2019-09-08T00:41:34.7256716Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-09-08T01:54:01Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-08T00:45:21.0191927Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-08T00:45:21.0367871Z ##[command]git config gc.auto 0
2019-09-08T00:45:21.0443146Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-08T00:45:21.0518236Z ##[command]git config --get-all http.proxy
2019-09-08T00:45:21.0654984Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64078/merge:refs/remotes/pull/64078/merge
---
2019-09-08T01:43:40.8936076Z .................................................................................................... 1500/9006
2019-09-08T01:43:46.3328932Z .................................................................................................... 1600/9006
2019-09-08T01:43:58.1068063Z ......................................................i...............i............................. 1700/9006
2019-09-08T01:44:05.3131044Z .................................................................................................... 1800/9006
2019-09-08T01:44:18.7417957Z .............................................iiiii.................................................. 1900/9006
2019-09-08T01:44:28.8671447Z .................................................................................................... 2100/9006
2019-09-08T01:44:31.1839842Z .................................................................................................... 2200/9006
2019-09-08T01:44:34.5078417Z .................................................................................................... 2300/9006
2019-09-08T01:44:41.8659421Z .................................................................................................... 2400/9006
---
2019-09-08T01:47:26.9230375Z .................................i...............i.................................................. 4700/9006
2019-09-08T01:47:38.1881677Z .................................................................................................... 4800/9006
2019-09-08T01:47:44.1552558Z .................................................................................................... 4900/9006
2019-09-08T01:47:54.4999179Z .................................................................................................... 5000/9006
2019-09-08T01:48:00.2539802Z ...............ii.ii................................................................................ 5100/9006
2019-09-08T01:48:10.2669532Z .................................................................................................... 5300/9006
2019-09-08T01:48:19.7977448Z ..............................................................................i..................... 5400/9006
2019-09-08T01:48:26.7965373Z .................................................................................................... 5500/9006
2019-09-08T01:48:32.3917981Z .................................................................................................... 5600/9006
2019-09-08T01:48:32.3917981Z .................................................................................................... 5600/9006
2019-09-08T01:48:42.1978433Z ........................................................................ii...i..ii...........i...... 5700/9006
2019-09-08T01:49:05.3266136Z .................................................................................................... 5900/9006
2019-09-08T01:49:14.1742304Z .................................................................................................... 6000/9006
2019-09-08T01:49:14.1742304Z .................................................................................................... 6000/9006
2019-09-08T01:49:19.7464654Z ..........................................................................i..ii..................... 6100/9006
2019-09-08T01:49:46.8951878Z .................................................................................................... 6300/9006
2019-09-08T01:49:48.6731167Z .................................i.................................................................. 6400/9006
2019-09-08T01:49:50.5860163Z .................................................................................................... 6500/9006
2019-09-08T01:49:52.9394297Z .....i.............................................................................................. 6600/9006
---
2019-09-08T01:53:36.3161350Z failures:
2019-09-08T01:53:36.3185771Z 
2019-09-08T01:53:36.3186237Z ---- [ui] ui/borrowck/borrowck-migrate-to-nll.rs#zflag stdout ----
2019-09-08T01:53:36.3186303Z 
2019-09-08T01:53:36.3186346Z error in revision `zflag`: ui test compiled successfully!
2019-09-08T01:53:36.3186386Z status: exit code: 0
2019-09-08T01:53:36.3187066Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/borrowck/borrowck-migrate-to-nll.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "zflag" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.zflag" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "borrowck=migrate" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.zflag/auxiliary" "-A" "unused"
2019-09-08T01:53:36.3187678Z ------------------------------------------
2019-09-08T01:53:36.3187714Z 
2019-09-08T01:53:36.3187908Z ------------------------------------------
2019-09-08T01:53:36.3187947Z stderr:
2019-09-08T01:53:36.3187947Z stderr:
2019-09-08T01:53:36.3188147Z ------------------------------------------
2019-09-08T01:53:36.3188196Z warning[E0502]: cannot borrow `*block.current` as immutable because it is also borrowed as mutable
2019-09-08T01:53:36.3189060Z    |
2019-09-08T01:53:36.3189109Z LL |     let x = &mut block;
2019-09-08T01:53:36.3189381Z    |             ---------- mutable borrow occurs here
2019-09-08T01:53:36.3189381Z    |             ---------- mutable borrow occurs here
2019-09-08T01:53:36.3189674Z LL |     let p: &'a u8 = &*block.current;
2019-09-08T01:53:36.3189737Z    |                     ^^^^^^^^^^^^^^^ immutable borrow occurs here
2019-09-08T01:53:36.3189860Z LL |     drop(x);
2019-09-08T01:53:36.3189860Z LL |     drop(x);
2019-09-08T01:53:36.3190124Z    |          - mutable borrow later used here
2019-09-08T01:53:36.3190253Z    = warning: this error has been downgraded to a warning for backwards compatibility with previous releases
2019-09-08T01:53:36.3190324Z    = warning: this represents potential undefined behavior in your code and this warning will become a hard error in the future
2019-09-08T01:53:36.3190605Z    = note: for more information, try `rustc --explain E0729`
2019-09-08T01:53:36.3190666Z 
---
2019-09-08T01:53:36.3221078Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-08T01:53:36.3221207Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-08T01:53:36.3235371Z 
2019-09-08T01:53:36.3235452Z 
2019-09-08T01:53:36.3236935Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-08T01:53:36.3237150Z 
2019-09-08T01:53:36.3237175Z 
2019-09-08T01:53:36.3247485Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-08T01:53:36.3247617Z Build completed unsuccessfully in 1:00:51
2019-09-08T01:53:36.3247617Z Build completed unsuccessfully in 1:00:51
2019-09-08T01:53:36.3297065Z == clock drift check ==
2019-09-08T01:53:36.9486760Z   local time: Sun Sep  8 01:53:36 UTC 2019
2019-09-08T01:53:36.9487348Z   network time: Sun, 08 Sep 2019 01:53:36 GMT
2019-09-08T01:53:36.9487488Z == end clock drift check ==
2019-09-08T01:53:37.5325109Z ##[error]Bash exited with code '1'.
2019-09-08T01:53:37.5361433Z ##[section]Starting: Checkout
2019-09-08T01:53:37.5363837Z ==============================================================================
2019-09-08T01:53:37.5363903Z Task         : Get sources
2019-09-08T01:53:37.5363953Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-09-08T14:39:12Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-08T13:24:45.5554953Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-08T13:24:45.5788168Z ##[command]git config gc.auto 0
2019-09-08T13:24:45.5887476Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-08T13:24:45.5954855Z ##[command]git config --get-all http.proxy
2019-09-08T13:24:45.6116818Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64078/merge:refs/remotes/pull/64078/merge
---
2019-09-08T14:28:03.0157742Z .................................................................................................... 1500/9008
2019-09-08T14:28:08.5174232Z .................................................................................................... 1600/9008
2019-09-08T14:28:21.1586037Z ......................................................i...............i............................. 1700/9008
2019-09-08T14:28:29.0051015Z .................................................................................................... 1800/9008
2019-09-08T14:28:44.5260892Z .............................................iiiii.................................................. 1900/9008
2019-09-08T14:28:54.6472427Z .................................................................................................... 2100/9008
2019-09-08T14:28:57.2120846Z .................................................................................................... 2200/9008
2019-09-08T14:29:00.8208332Z .................................................................................................... 2300/9008
2019-09-08T14:29:08.8439604Z .................................................................................................... 2400/9008
---
2019-09-08T14:32:06.6248126Z ..................................i...............i................................................. 4700/9008
2019-09-08T14:32:18.8661063Z .................................................................................................... 4800/9008
2019-09-08T14:32:25.4105925Z .................................................................................................... 4900/9008
2019-09-08T14:32:36.7621013Z .................................................................................................... 5000/9008
2019-09-08T14:32:42.9449035Z ................ii.ii............................................................................... 5100/9008
2019-09-08T14:32:53.5290442Z .................................................................................................... 5300/9008
2019-09-08T14:33:03.5869790Z ...............................................................................i.................... 5400/9008
2019-09-08T14:33:11.4098730Z .................................................................................................... 5500/9008
2019-09-08T14:33:17.4324116Z .................................................................................................... 5600/9008
2019-09-08T14:33:17.4324116Z .................................................................................................... 5600/9008
2019-09-08T14:33:28.6329581Z .........................................................................ii...i..ii...........i..... 5700/9008
2019-09-08T14:33:53.4463525Z .................................................................................................... 5900/9008
2019-09-08T14:34:02.6559297Z .................................................................................................... 6000/9008
2019-09-08T14:34:02.6559297Z .................................................................................................... 6000/9008
2019-09-08T14:34:09.8884373Z ...........................................................................i..ii.................... 6100/9008
2019-09-08T14:34:38.7461878Z .................................................................................................... 6300/9008
2019-09-08T14:34:41.0012799Z ..................................i................................................................. 6400/9008
2019-09-08T14:34:43.3214286Z .................................................................................................... 6500/9008
2019-09-08T14:34:45.9593111Z ......i............................................................................................. 6600/9008
---
2019-09-08T14:38:49.4595535Z 15 
2019-09-08T14:38:49.4595558Z 
2019-09-08T14:38:49.4595596Z 
2019-09-08T14:38:49.4595632Z The actual stderr differed from the expected stderr.
2019-09-08T14:38:49.4595898Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.zflag/borrowck-migrate-to-nll.zflag.stderr
2019-09-08T14:38:49.4596113Z To update references, rerun the tests and pass the `--bless` flag
2019-09-08T14:38:49.4596360Z To only update this specific test, also pass `--test-args borrowck/borrowck-migrate-to-nll.rs`
2019-09-08T14:38:49.4596392Z 
2019-09-08T14:38:49.4596447Z error in revision `zflag`: 1 errors occurred comparing output.
2019-09-08T14:38:49.4596486Z status: exit code: 0
2019-09-08T14:38:49.4597175Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/borrowck/borrowck-migrate-to-nll.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "zflag" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.zflag" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "borrowck=migrate" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/borrowck-migrate-to-nll.zflag/auxiliary" "-A" "unused"
2019-09-08T14:38:49.4597471Z ------------------------------------------
2019-09-08T14:38:49.4597517Z 
2019-09-08T14:38:49.4597704Z ------------------------------------------
2019-09-08T14:38:49.4597743Z stderr:
2019-09-08T14:38:49.4597743Z stderr:
2019-09-08T14:38:49.4597943Z ------------------------------------------
2019-09-08T14:38:49.4597999Z warning[E0502]: cannot borrow `*block.current` as immutable because it is also borrowed as mutable
2019-09-08T14:38:49.4598287Z    |
2019-09-08T14:38:49.4598324Z LL |     let x = &mut block;
2019-09-08T14:38:49.4598521Z    |             ---------- mutable borrow occurs here
2019-09-08T14:38:49.4598521Z    |             ---------- mutable borrow occurs here
2019-09-08T14:38:49.4598706Z LL |     let p: &'a u8 = &*block.current;
2019-09-08T14:38:49.4598768Z    |                     ^^^^^^^^^^^^^^^ immutable borrow occurs here
2019-09-08T14:38:49.4598840Z LL |     drop(x);
2019-09-08T14:38:49.4598840Z LL |     drop(x);
2019-09-08T14:38:49.4599049Z    |          - mutable borrow later used here
2019-09-08T14:38:49.4599131Z    = warning: this error has been downgraded to a warning for backwards compatibility with previous releases
2019-09-08T14:38:49.4599376Z    = warning: this represents potential undefined behavior in your code and this warning will become a hard error in the future
2019-09-08T14:38:49.4599596Z    = note: for more information, try `rustc --explain E0729`
2019-09-08T14:38:49.4599628Z 
---
2019-09-08T14:38:49.4639073Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-08T14:38:49.4639163Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-08T14:38:49.4655120Z 
2019-09-08T14:38:49.4655381Z 
2019-09-08T14:38:49.4657492Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-08T14:38:49.4658106Z 
2019-09-08T14:38:49.4658132Z 
2019-09-08T14:38:49.4665804Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-08T14:38:49.4665903Z Build completed unsuccessfully in 1:06:56
2019-09-08T14:38:49.4665903Z Build completed unsuccessfully in 1:06:56
2019-09-08T14:38:49.4719893Z == clock drift check ==
2019-09-08T14:38:49.4736829Z   local time: Sun Sep  8 14:38:49 UTC 2019
2019-09-08T14:38:49.6269359Z   network time: Sun, 08 Sep 2019 14:38:49 GMT
2019-09-08T14:38:49.6269478Z == end clock drift check ==
2019-09-08T14:38:50.3167878Z ##[error]Bash exited with code '1'.
2019-09-08T14:38:50.3223484Z ##[section]Starting: Checkout
2019-09-08T14:38:50.3225483Z ==============================================================================
2019-09-08T14:38:50.3225553Z Task         : Get sources
2019-09-08T14:38:50.3225604Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2019-09-08T17:54:56Z

@bors r=petrochenkov

bors · 2019-09-08T17:54:57Z

📌 Commit 6fdbece has been approved by petrochenkov

bors · 2019-09-08T20:27:03Z

⌛ Testing commit 6fdbece with merge 288962a9274795bf6f0d30ea002fd371df6fdb41...

@petrochenkov

…used, r=petrochenkov compiletest: disable -Aunused for run-pass tests Disabled the flag, but that led to quite a bit of fall out -- I think most of it is benign but I've not investigated thoroughly. r? @petrochenkov

Centril · 2019-09-08T20:51:17Z

@bors retry rolled up.

@ghost

Rollup of 4 pull requests Successful merges: - #64078 (compiletest: disable -Aunused for run-pass tests) - #64263 (Replace "feature gated" wording with "unstable".) - #64280 (Factor out pluralisation into syntax::errors) - #64288 (use 'get_toml' instead of regular expression) Failed merges: r? @ghost

bors · 2019-09-09T00:58:05Z

⌛ Testing commit 6fdbece with merge a6624ed...

rust-highfive assigned petrochenkov Sep 1, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2019

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from 433711e to 77bd34a Compare September 2, 2019 19:24

Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2019

Centril reviewed Sep 2, 2019

View reviewed changes

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from 77bd34a to a959b47 Compare September 2, 2019 21:51

petrochenkov reviewed Sep 2, 2019

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2019

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from a959b47 to 09a442d Compare September 3, 2019 15:24

Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2019

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from 51ad535 to b338903 Compare September 6, 2019 21:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2019

run-pass tests shouldn't have unused contents

072942d

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from b338903 to cb41ce3 Compare September 7, 2019 23:29

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from cb41ce3 to c17e109 Compare September 8, 2019 00:44

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from c17e109 to cf8a499 Compare September 8, 2019 13:24

Update test stderr with results of enabling unused lints

6fdbece

Mark-Simulacrum force-pushed the compiletest-lint-unused branch from cf8a499 to 6fdbece Compare September 8, 2019 15:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2019

Centril mentioned this pull request Sep 8, 2019

Rollup of 4 pull requests #64293

Merged

bors merged commit 6fdbece into rust-lang:master Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compiletest: disable -Aunused for run-pass tests #64078

compiletest: disable -Aunused for run-pass tests #64078

Mark-Simulacrum commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

Centril commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

Centril commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

petrochenkov commented Sep 1, 2019 •

edited

Loading

Centril commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

rust-highfive commented Sep 1, 2019

RalfJung commented Sep 2, 2019

Mark-Simulacrum commented Sep 2, 2019

Mark-Simulacrum commented Sep 2, 2019

Mark-Simulacrum commented Sep 3, 2019

petrochenkov commented Sep 3, 2019

bors commented Sep 3, 2019

Mark-Simulacrum commented Sep 6, 2019

bors commented Sep 6, 2019

rust-highfive commented Sep 6, 2019

Mark-Simulacrum commented Sep 7, 2019

rust-highfive commented Sep 8, 2019

rust-highfive commented Sep 8, 2019

rust-highfive commented Sep 8, 2019

Mark-Simulacrum commented Sep 8, 2019

bors commented Sep 8, 2019

bors commented Sep 8, 2019

Centril commented Sep 8, 2019

bors commented Sep 9, 2019

compiletest: disable -Aunused for run-pass tests #64078

compiletest: disable -Aunused for run-pass tests #64078

Conversation

Mark-Simulacrum commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

Centril commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

Centril commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

petrochenkov commented Sep 1, 2019 • edited Loading

Centril commented Sep 1, 2019

Mark-Simulacrum commented Sep 1, 2019

rust-highfive commented Sep 1, 2019

RalfJung commented Sep 2, 2019

Mark-Simulacrum commented Sep 2, 2019

Mark-Simulacrum commented Sep 2, 2019

Mark-Simulacrum commented Sep 3, 2019

petrochenkov commented Sep 3, 2019

bors commented Sep 3, 2019

Mark-Simulacrum commented Sep 6, 2019

bors commented Sep 6, 2019

rust-highfive commented Sep 6, 2019

Mark-Simulacrum commented Sep 7, 2019

rust-highfive commented Sep 8, 2019

rust-highfive commented Sep 8, 2019

rust-highfive commented Sep 8, 2019

Mark-Simulacrum commented Sep 8, 2019

bors commented Sep 8, 2019

bors commented Sep 8, 2019

Centril commented Sep 8, 2019

bors commented Sep 9, 2019

petrochenkov commented Sep 1, 2019 •

edited

Loading