Use while let slice_pattern instead of carrying an index around #64518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit d1f763f has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 16, 2019
…r-proj-slice, r=oli-obk Use while let slice_pattern instead of carrying an index around r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 16, 2019
…r-proj-slice, r=oli-obk Use while let slice_pattern instead of carrying an index around r? @oli-obk
Centril
reviewed
Sep 16, 2019
| @@ -614,8 +614,9 @@ impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> { | |||
| projection, | |||
| } = first_borrowed_place; | |||
|
|
|||
| for (i, elem) in projection.iter().enumerate().rev() { | |||
| let proj_base = &projection[..i]; | |||
| let mut cursor = &**projection; | |||
There was a problem hiding this comment.
Can we refactor this idiom into a method on projection to reduce the repetition?
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 16, 2019
…r-proj-slice, r=oli-obk Use while let slice_pattern instead of carrying an index around r? @oli-obk
bors
added a commit
that referenced
this pull request
Sep 16, 2019
Rollup of 4 pull requests Successful merges: - #64357 (`AdtDef` is an algebraic data type, not abstract data type) - #64485 (update Miri) - #64509 (Make some adjustments to the documentation for `std::convert::identity`) - #64518 (Use while let slice_pattern instead of carrying an index around) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk