Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example to Pin::as_mut #64529

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Add an example to Pin::as_mut #64529

merged 2 commits into from
Sep 18, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Sep 16, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2019
@taiki-e taiki-e mentioned this pull request Sep 17, 2019
Closed
jonhoo
jonhoo reviewed Sep 17, 2019
View reviewed changes
src/libcore/pin.rs Outdated Show resolved Hide resolved
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-09-17T00:56:32.8780855Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-17T00:56:32.8968040Z ##[command]git config gc.auto 0
2019-09-17T00:56:32.9039178Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-17T00:56:32.9106228Z ##[command]git config --get-all http.proxy
2019-09-17T00:56:32.9267115Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64529/merge:refs/remotes/pull/64529/merge
---
2019-09-17T02:01:56.2033448Z .................................................................................................... 1500/9022
2019-09-17T02:02:02.6074036Z .................................................................................................... 1600/9022
2019-09-17T02:02:16.1490040Z ...............................................................i...............i.................... 1700/9022
2019-09-17T02:02:23.7984097Z .................................................................................................... 1800/9022
2019-09-17T02:02:40.3219920Z ......................................................iiiii......................................... 1900/9022
2019-09-17T02:02:52.6349868Z .................................................................................................... 2100/9022
2019-09-17T02:02:55.4664375Z .................................................................................................... 2200/9022
2019-09-17T02:02:59.2823846Z .................................................................................................... 2300/9022
2019-09-17T02:03:08.2167887Z .................................................................................................... 2400/9022
---
2019-09-17T02:06:19.7036190Z ..........................................i...............i......................................... 4700/9022
2019-09-17T02:06:31.6873204Z .................................................................................................... 4800/9022
2019-09-17T02:06:39.2017292Z .................................................................................................... 4900/9022
2019-09-17T02:06:49.3977174Z .................................................................................................... 5000/9022
2019-09-17T02:06:57.6046514Z ..........................ii.ii..................................................................... 5100/9022
2019-09-17T02:07:08.7581865Z .................................................................................................... 5300/9022
2019-09-17T02:07:19.6025539Z ..........................................................................................i......... 5400/9022
2019-09-17T02:07:28.3554077Z .................................................................................................... 5500/9022
2019-09-17T02:07:33.6952840Z .................................................................................................... 5600/9022
2019-09-17T02:07:33.6952840Z .................................................................................................... 5600/9022
2019-09-17T02:07:44.8921033Z .....................................................................................ii...i..ii..... 5700/9022
2019-09-17T02:08:11.8095007Z .................................................................................................... 5900/9022
2019-09-17T02:08:22.5671394Z .................................................................................................... 6000/9022
2019-09-17T02:08:22.5671394Z .................................................................................................... 6000/9022
2019-09-17T02:08:32.2477367Z .......................................................................................i..ii........ 6100/9022
2019-09-17T02:09:03.7971194Z .................................................................................................... 6300/9022
2019-09-17T02:09:07.8641577Z ..............................................i..................................................... 6400/9022
2019-09-17T02:09:10.2022089Z .................................................................................................... 6500/9022
2019-09-17T02:09:12.9145475Z ..................i................................................................................. 6600/9022
---
2019-09-17T02:14:03.8637603Z  finished in 5.462
2019-09-17T02:14:03.8834671Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-17T02:14:04.0861813Z 
2019-09-17T02:14:04.0862851Z running 150 tests
2019-09-17T02:14:07.5825251Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-09-17T02:14:10.2479801Z ..iiii..............i.........iii.i.......ii......
2019-09-17T02:14:10.2539833Z 
2019-09-17T02:14:10.2539921Z  finished in 5.845
2019-09-17T02:14:10.2540322Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-17T02:14:10.2540371Z 
---
2019-09-17T02:14:12.1762678Z  finished in 2.427
2019-09-17T02:14:12.1978668Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-17T02:14:13.2490577Z 
2019-09-17T02:14:13.2490679Z running 9 tests
2019-09-17T02:14:13.2491755Z iiiiiiiii
2019-09-17T02:14:13.2492119Z 
2019-09-17T02:14:13.2492159Z  finished in 0.183
2019-09-17T02:14:13.2492458Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-17T02:14:13.2492511Z 
---
2019-09-17T02:14:32.1511679Z  finished in 19.749
2019-09-17T02:14:32.1764438Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-17T02:14:33.2537641Z 
2019-09-17T02:14:33.2537765Z running 123 tests
2019-09-17T02:14:58.5277305Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-17T02:15:03.5054391Z i.i.i......iii.i.....ii
2019-09-17T02:15:03.5055482Z 
2019-09-17T02:15:03.5061236Z  finished in 31.329
2019-09-17T02:15:03.5071288Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-17T02:15:03.5074824Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-17T02:29:47.0168057Z 
2019-09-17T02:29:47.0216296Z    Doc-tests core
2019-09-17T02:29:51.8375338Z 
2019-09-17T02:29:51.8375686Z running 2401 tests
2019-09-17T02:30:03.9661945Z ......iiiii......................................................................................... 100/2401
2019-09-17T02:30:15.4941268Z ...........................................................................ii....................... 200/2401
2019-09-17T02:30:28.7500196Z .................................................................................................i.. 300/2401
2019-09-17T02:30:43.0353519Z .................................................................................................... 400/2401
2019-09-17T02:30:54.2706422Z ............................................i..i.................iiii............................... 500/2401
2019-09-17T02:31:16.1678233Z .................................................................................................... 700/2401
2019-09-17T02:31:27.3941923Z .................................................................................................... 800/2401
2019-09-17T02:31:38.6865997Z .................................................................................................... 900/2401
2019-09-17T02:31:49.9341858Z .................................................................................................... 1000/2401
---
2019-09-17T02:34:35.2209649Z ---- pin.rs - pin::Pin<P>::as_mut (line 590) stdout ----
2019-09-17T02:34:35.2210999Z error[E0425]: cannot find value `x` in this scope
2019-09-17T02:34:35.2211339Z   --> pin.rs:601:9
2019-09-17T02:34:35.2211410Z    |
2019-09-17T02:34:35.2211451Z 14 |         x.as_mut().method();
2019-09-17T02:34:35.2211491Z    |         ^ not found in this scope
2019-09-17T02:34:35.2211577Z error[E0425]: cannot find value `x` in this scope
2019-09-17T02:34:35.2211781Z   --> pin.rs:602:9
2019-09-17T02:34:35.2211821Z    |
2019-09-17T02:34:35.2211875Z 15 |         x.method();
---
2019-09-17T02:34:35.2213332Z 
2019-09-17T02:34:35.2331230Z error: test failed, to rerun pass '--doc'
2019-09-17T02:34:35.2341215Z 
2019-09-17T02:34:35.2341320Z 
2019-09-17T02:34:35.2342094Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "core" "--" "--quiet"
2019-09-17T02:34:35.2342218Z 
2019-09-17T02:34:35.2342258Z 
2019-09-17T02:34:35.2350329Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-17T02:34:35.2350395Z Build completed unsuccessfully in 1:30:37
2019-09-17T02:34:35.2350395Z Build completed unsuccessfully in 1:30:37
2019-09-17T02:34:35.2401696Z == clock drift check ==
2019-09-17T02:34:35.2416531Z   local time: Tue Sep 17 02:34:35 UTC 2019
2019-09-17T02:34:35.3941400Z   network time: Tue, 17 Sep 2019 02:34:35 GMT
2019-09-17T02:34:35.3943373Z == end clock drift check ==
2019-09-17T02:34:36.0233827Z ##[error]Bash exited with code '1'.
2019-09-17T02:34:36.0274574Z ##[section]Starting: Checkout
2019-09-17T02:34:36.0277055Z ==============================================================================
2019-09-17T02:34:36.0277134Z Task         : Get sources
2019-09-17T02:34:36.0277198Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RalfJung
RalfJung reviewed Sep 17, 2019
View reviewed changes
src/libcore/pin.rs Outdated Show resolved Hide resolved
RalfJung
RalfJung reviewed Sep 17, 2019
View reviewed changes
src/libcore/pin.rs Outdated Show resolved Hide resolved
RalfJung
RalfJung reviewed Sep 17, 2019
View reviewed changes
src/libcore/pin.rs Outdated Show resolved Hide resolved
@taiki-e @RalfJung
Update src/libcore/pin.rs
a22e9ee 
Co-Authored-By: Ralf Jung <post@ralfj.de>
@RalfJung
Copy link
Member

Thanks. :)
@bors rollup delegate+
r=me when CI in the PR is green (which means you can then write bors r=RalfJung)

@bors
Copy link
Contributor

bors commented Sep 17, 2019

✌️ @taiki-e can now approve this pull request

@taiki-e
Copy link
Member Author

taiki-e commented Sep 17, 2019

@bors r=RalfJung

CI passed.

@bors
Copy link
Contributor

bors commented Sep 17, 2019

📌 Commit a22e9ee has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 17, 2019
@tmandry
Rollup merge of rust-lang#64529 - taiki-e:docs-pin-as-mut, r=RalfJung
4cb6df5 
Add an example to Pin::as_mut

taiki-e/pin-project#89 (comment)

r? @RalfJung
@tmandry tmandry mentioned this pull request Sep 17, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 17, 2019
@tmandry
Rollup merge of rust-lang#64529 - taiki-e:docs-pin-as-mut, r=RalfJung
44308d3 
Add an example to Pin::as_mut

taiki-e/pin-project#89 (comment)

r? @RalfJung
@tmandry tmandry mentioned this pull request Sep 17, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 17, 2019
@tmandry
Rollup merge of rust-lang#64529 - taiki-e:docs-pin-as-mut, r=RalfJung
d782f09 
Add an example to Pin::as_mut

taiki-e/pin-project#89 (comment)

r? @RalfJung
@tmandry tmandry mentioned this pull request Sep 17, 2019
Merged
bors added a commit that referenced this pull request Sep 17, 2019
@bors
Auto merge of #64562 - tmandry:rollup-kfk0nuo, r=tmandry
5283791 
Rollup of 10 pull requests

Successful merges:

 - #61626 (Get rid of special const intrinsic query in favour of `const_eval`)
 - #64283 (Updated RELEASES.md for 1.38.0)
 - #64394 (Shrink `SubregionOrigin`.)
 - #64429 (Fix failure note `to_str` implementation)
 - #64436 (improve Vec example soundness in mem::transmute docs)
 - #64502 (avoid duplicate issues for Miri build failures)
 - #64505 (Fix inconsistent link formatting)
 - #64529 (Add an example to Pin::as_mut)
 - #64541 (document Miri error categories)
 - #64544 (build-manifest: re-add some comments)

Failed merges:

r? @ghost
@bors bors merged commit a22e9ee into rust-lang:master Sep 18, 2019
@taiki-e taiki-e deleted the docs-pin-as-mut branch September 18, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@jonhoo jonhoo jonhoo left review comments

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taiki-e @rust-highfive @RalfJung @bors @jonhoo