Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] rollup of last set of backports #64661

Merged
merged 4 commits into from
Sep 22, 2019
Merged

[beta] rollup of last set of backports #64661

merged 4 commits into from
Sep 22, 2019

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Sep 21, 2019 •
edited
Loading

XAMPPRocky and others added 4 commits September 21, 2019 12:26
@XAMPPRocky @Mark-Simulacrum
Updated RELEASES.md for 1.38.0
d8052d8
@pnkfelix @Mark-Simulacrum
Make fn ptr always structural match, regardless of whether formal typ…
f3ebfab 
…es are.

Fix rust-lang#63479.
@pnkfelix @Mark-Simulacrum
Regression tests for fn ptr and #[structural_match] as discussed in r…
73c70ca 
…ust-lang#63479.
@pietroalbini @Mark-Simulacrum
ci: split aws credentials in two separate users with scoped perms
e8d2957 
This commit changes our CI to use two separate IAM users to
authenticate with AWS:

* ci--rust-lang--rust--sccache: has access to the rust-lang-ci-sccache2
  S3 bucket and its credentials are available during the whole build.
* ci--rust-lang--rust--upload: has access to the rust-lang-ci2 S3 bucket
  and its credentials are available just during the upload step.

The new tokens are available in the `prod-credentials` library.
@Centril Centril closed this Sep 21, 2019
@Centril Centril reopened this Sep 21, 2019
@Mark-Simulacrum
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Sep 21, 2019

⌛ Trying commit e8d2957 with merge cab0dd4d50cabfc3b268acb5b7f5247be485dc9a...

@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=50

@bors
Copy link
Contributor

bors commented Sep 21, 2019

📌 Commit e8d2957 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 21, 2019
@bors
Copy link
Contributor

bors commented Sep 21, 2019

⌛ Testing commit e8d2957 with merge 39dabb998bc2a9da811ccf144955c16f90aefd2d...

@bors
Copy link
Contributor

bors commented Sep 21, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2019
@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019
@bors
Copy link
Contributor

bors commented Sep 21, 2019

⌛ Testing commit e8d2957 with merge 1c65325...

bors added a commit that referenced this pull request Sep 21, 2019
@bors
Auto merge of #64661 - Mark-Simulacrum:beta-next, r=Mark-Simulacrum
1c65325 
[beta] rollup of last set of backports

* ci: split aws credentials in two separate users with scoped perms #64576
* Updated RELEASES.md for 1.38.0 #64283
* Add Compatibility Notes to RELEASES.md for 1.38.0 #64621
@bors
Copy link
Contributor

bors commented Sep 22, 2019

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 1c65325 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2019
@bors bors merged commit e8d2957 into rust-lang:beta Sep 22, 2019
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mark-Simulacrum @bors @Centril @XAMPPRocky @pnkfelix @pietroalbini