Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize UdpSocket::peer_addr #64728

Merged
merged 2 commits into from
Oct 6, 2019
Merged

Stabilize UdpSocket::peer_addr #64728

merged 2 commits into from
Oct 6, 2019

Conversation

messense
Copy link
Contributor

Fixes #59127

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2019
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 24, 2019
@jonas-schievink jonas-schievink added this to the 1.40 milestone Sep 24, 2019
hellow554
hellow554 reviewed Sep 24, 2019
View reviewed changes
src/libstd/net/udp.rs Outdated Show resolved Hide resolved
@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Sep 24, 2019
@jonas-schievink jonas-schievink modified the milestones: 1.40, 1.39 Sep 24, 2019
@Centril Centril modified the milestones: 1.39, 1.40 Sep 26, 2019
Centril
Centril reviewed Sep 26, 2019
View reviewed changes
src/libstd/net/udp.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Sep 26, 2019

Picking randomly from T-libs... r? @dtolnay

@Centril
Update src/libstd/net/udp.rs
1de6f74 
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
dtolnay
dtolnay approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Oct 4, 2019

Libs fcp was already completed in #59127 (comment).

@bors r+

@bors
Copy link
Contributor

bors commented Oct 4, 2019

📌 Commit 1de6f74 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2019
@dtolnay dtolnay removed the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Oct 4, 2019
@bors
Copy link
Contributor

bors commented Oct 5, 2019

⌛ Testing commit 1de6f74 with merge 079eef10d7da246d8d9dba311de63d7359579002...

@bors
Copy link
Contributor

bors commented Oct 5, 2019

💥 Test timed out

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 5, 2019
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2019
@tmandry
Copy link
Member

tmandry commented Oct 6, 2019

@bors r=dtolnay

@bors
Copy link
Contributor

bors commented Oct 6, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Rollup of 15 pull requests #65139

@bors
Copy link
Contributor

bors commented Oct 6, 2019

📌 Commit 1de6f74 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 6, 2019
@tmandry
Rollup merge of rust-lang#64728 - messense:udp-peer-addr, r=dtolnay
019b5b5 
Stabilize UdpSocket::peer_addr

Fixes rust-lang#59127
@tmandry tmandry mentioned this pull request Oct 6, 2019
Merged
bors added a commit that referenced this pull request Oct 6, 2019
@bors
Auto merge of #65152 - tmandry:rollup-btn4a01, r=tmandry
5a8fb7c 
Rollup of 18 pull requests

This contains changes from all the successful runs that bors marked as timed out, plus a revert of #63649 which appears to be the immediate cause of the timeouts.

Successful merges:

 - #64708 (Stabilize `Option::as_deref` and `Option::as_deref_mut`)
 - #64728 (Stabilize UdpSocket::peer_addr)
 - #64765 (std: Reduce checks for `feature = "backtrace"`)
 - #64909 (When encountering chained operators use heuristics to recover from bad turbofish)
 - #65011 (Do not ICE when dereferencing non-Copy raw pointer)
 - #65064 (permit asyncawait-ondeck to be added by anyone)
 - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR)
 - #65100 (Replace GeneratorSubsts with SubstsRef)
 - #65105 (Split out some passes from librustc)
 - #65106 (Allow unused attributes to avoid incremental bug)
 - #65113 (Fix lonely backtick)
 - #65116 (Remove unneeded visit_statement definition)
 - #65118 (Update the documented default of -Z mutable-noalias)
 - #65123 (Account for macro invocation in `let mut $pat` diagnostic.)
 - #65124 (Replace some instances of `as *[const | mut] _` with `.cast()`)
 - #65126 (Fix typo on `now()` comments)
 - #65130 (lint: extern non-exhaustive types are improper)
 - #65151 (Revert #63649 - "Upgrade Emscripten targets to use upstream LLVM backend")

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Oct 6, 2019

⌛ Testing commit 1de6f74 with merge 5a8fb7c...

@bors bors merged commit 1de6f74 into rust-lang:master Oct 6, 2019
@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Oct 6, 2019
Closed
@messense messense deleted the udp-peer-addr branch October 6, 2019 14:12
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

@hellow554 hellow554 hellow554 left review comments

@Centril Centril Centril left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.

Tracking issue for udp_peer_addr
9 participants
@messense @rust-highfive @Centril @dtolnay @bors @tmandry @hellow554 @jonas-schievink @withoutboats