Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blanket silencing of "type annotation needed" errors #64746

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Remove blanket silencing of "type annotation needed" errors #64746

merged 3 commits into from
Sep 25, 2019

Commits on Sep 24, 2019

  1. Remove blanket silencing of "type annotation needed" errors 

    Remove blanket check for existence of other errors before emitting
"type annotation needed" errors, and add some eager checks to avoid
adding obligations when they refer to types that reference
`[type error]` in order to reduce unneded errors.
    @estebank
    estebank committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    d9ab4ff View commit details
    Browse the repository at this point in the history

  2. clean up, push silencing logic to more relevant places

    @estebank
    estebank committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    affa038 View commit details
    Browse the repository at this point in the history

  3. fix rebase

    @estebank
    estebank committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    b7ca1c5 View commit details
    Browse the repository at this point in the history