Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated RELEASES.md for 1.39.0 #64878

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Updated RELEASES.md for 1.39.0 #64878

merged 1 commit into from
Nov 4, 2019

Conversation

XAMPPRocky
Copy link
Member

Rendered

r? @Mark-Simulacrum
cc @rust-lang/release

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2019
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-release Relevant to the release subteam, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2019
jonas-schievink
jonas-schievink reviewed Sep 28, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
ghost
ghost suggested changes Sep 28, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Show resolved Hide resolved
Centril
Centril reviewed Sep 28, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
ehuss
ehuss reviewed Sep 28, 2019
View reviewed changes
RELEASES.md Show resolved Hide resolved
phansch
phansch reviewed Sep 29, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
Centril
Centril reviewed Sep 29, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
mominul
mominul reviewed Sep 29, 2019
View reviewed changes
RELEASES.md Show resolved Hide resolved
@ehuss ehuss mentioned this pull request Sep 30, 2019
Merged
@JohnCSimon
Copy link
Member

Ping from triage:
@Mark-Simulacrum this PR looks like it's still waiting on review.
Thanks.

Mark-Simulacrum
Mark-Simulacrum approved these changes Oct 17, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
Mark-Simulacrum
Mark-Simulacrum reviewed Oct 18, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
repnop
repnop reviewed Oct 25, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
pietroalbini
pietroalbini reviewed Oct 31, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
CryZe
CryZe reviewed Oct 31, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
tmandry
tmandry reviewed Oct 31, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
Centril
Centril reviewed Oct 31, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2019

📌 Commit 9e55d6fe0c6675fc84f923f5f0695daa0544aafe has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2019
@Mark-Simulacrum
Copy link
Member

@bors r-

Actually, could you squash this? I was going to do that myself and push it up but it seems I can't for some reason :/

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 1, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 1, 2019
Merged
@XAMPPRocky
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2019

📌 Commit 5fb4111 has been approved by XAMPPRocky

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 1, 2019
@XAMPPRocky
Copy link
Member Author

@Mark-Simulacrum Done.

@bors
Copy link
Contributor

bors commented Nov 1, 2019

⌛ Testing commit 5fb4111 with merge 7e2b84ee4e4d0b7fef834ea834822cb66d1be26e...

@rust-highfive
Copy link
Collaborator

The job x86_64-mingw-1 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-11-01T10:03:51.3114564Z do so (now or later) by using -b with the checkout command again. Example:
2019-11-01T10:03:51.3117158Z 
2019-11-01T10:03:51.3117359Z   git checkout -b <new-branch-name>
2019-11-01T10:03:51.3117432Z 
2019-11-01T10:03:51.3117509Z HEAD is now at 7e2b84ee4 Auto merge of #64878 - XAMPPRocky:relnotes-1.39.0, r=XAMPPRocky
2019-11-01T10:03:51.3490847Z ##[section]Starting: Decide whether to run this job
2019-11-01T10:03:51.3614973Z ==============================================================================
2019-11-01T10:03:51.3615073Z Task         : Bash
2019-11-01T10:03:51.3615148Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-11-01T10:03:52.8061158Z environment variables:
2019-11-01T10:03:52.8061201Z 
2019-11-01T10:03:52.8061231Z 
2019-11-01T10:03:52.8061285Z 
2019-11-01T10:03:52.8061353Z ### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes-1.39.0/RELEASES.md)
2019-11-01T10:03:52.8061517Z AGENT_DISABLELOGPLUGIN_TESTFILEPUBLISHERPLUGIN=true
2019-11-01T10:03:52.8061604Z AGENT_DISABLELOGPLUGIN_TESTRESULTLOGPLUGIN=true
2019-11-01T10:03:52.8061667Z AGENT_HOMEDIRECTORY=C:\agents\2.159.2
2019-11-01T10:03:52.8061745Z AGENT_ID=517
---
2019-11-01T10:03:52.8067043Z BUILD_SOURCEBRANCHNAME=auto
2019-11-01T10:03:52.8067118Z BUILD_SOURCESDIRECTORY=D:\a\1\s
2019-11-01T10:03:52.8067194Z BUILD_SOURCEVERSION=7e2b84ee4e4d0b7fef834ea834822cb66d1be26e
2019-11-01T10:03:52.8067279Z BUILD_SOURCEVERSIONAUTHOR=bors
2019-11-01T10:03:52.8067357Z BUILD_SOURCEVERSIONMESSAGE=Auto merge of #64878 - XAMPPRocky:relnotes-1.39.0, r=XAMPPRocky
2019-11-01T10:03:52.8067507Z COBERTURA_HOME=C:\cobertura-2.1.1
2019-11-01T10:03:52.8067590Z COMMONPROGRAMFILES=C:\Program Files\Common Files
2019-11-01T10:03:52.8067664Z COMMON_TESTRESULTSDIRECTORY=D:\a\1\TestResults
2019-11-01T10:03:52.8067743Z COMPUTERNAME=fv-az425
---
2019-11-01T11:33:26.8152111Z 
2019-11-01T11:33:26.8152169Z 
2019-11-01T11:33:26.8829793Z failed to run: D:\a\1\s\build\bootstrap\debug\bootstrap test --exclude src/test/ui --exclude src/test/compile-fail
2019-11-01T11:33:26.8829974Z Build completed unsuccessfully in 1:20:32
2019-11-01T11:33:26.9392950Z make: *** [Makefile:89: ci-mingw-subset-1] Error 1
2019-11-01T11:33:26.9979917Z   local time: Fri Nov  1 11:33:26 CUT 2019
2019-11-01T11:33:27.4171119Z   network time: Fri, 01 Nov 2019 11:33:27 GMT
2019-11-01T11:33:27.4171367Z == end clock drift check ==
2019-11-01T11:33:27.4838195Z 
2019-11-01T11:33:27.4838195Z 
2019-11-01T11:33:27.7883367Z ##[error]Bash exited with code '2'.
2019-11-01T11:33:27.8316371Z ##[section]Starting: Checkout
2019-11-01T11:33:27.9239814Z ==============================================================================
2019-11-01T11:33:27.9239920Z Task         : Get sources
2019-11-01T11:33:27.9240031Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 1, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 1, 2019
bors added a commit that referenced this pull request Nov 2, 2019
@bors
Auto merge of #66011 - Mark-Simulacrum:beta-backport, r=pietroalbini
32235c7 
[beta] backport rollup

* save-analysis: Account for async desugaring in async fn return types #65936
* resolve: Turn the "non-empty glob must import something" error into a lint #65539
* Updated RELEASES.md for 1.39.0 #64878 (squashed)
bors added a commit that referenced this pull request Nov 2, 2019
@bors
Auto merge of #66011 - Mark-Simulacrum:beta-backport, r=pietroalbini
5242afe 
[beta] backport rollup

* save-analysis: Account for async desugaring in async fn return types #65936
* resolve: Turn the "non-empty glob must import something" error into a lint #65539
* Updated RELEASES.md for 1.39.0 #64878 (squashed)
@Mark-Simulacrum
Copy link
Member

@bors retry

(This is not actually high priority, as we're not blocked on it -- this PR has already landed into beta and as such will be promoted into stable tomorrow)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2019
@bors
Copy link
Contributor

bors commented Nov 4, 2019

⌛ Testing commit 5fb4111 with merge cba9368...

bors added a commit that referenced this pull request Nov 4, 2019
@bors
Auto merge of #64878 - XAMPPRocky:relnotes-1.39.0, r=XAMPPRocky
cba9368 
Updated RELEASES.md for 1.39.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes-1.39.0/RELEASES.md)

r? @Mark-Simulacrum
cc @rust-lang/release
@bors
Copy link
Contributor

bors commented Nov 4, 2019

☀️ Test successful - checks-azure
Approved by: XAMPPRocky
Pushing cba9368 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2019
@bors bors merged commit 5fb4111 into rust-lang:master Nov 4, 2019
@XAMPPRocky XAMPPRocky deleted the relnotes-1.39.0 branch November 4, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repnop repnop repnop left review comments

@mominul mominul mominul left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

@pietroalbini pietroalbini pietroalbini left review comments

@tmandry tmandry tmandry left review comments

@phansch phansch phansch left review comments

@jonas-schievink jonas-schievink jonas-schievink left review comments

@CryZe CryZe CryZe left review comments

@Centril Centril Centril left review comments

@ehuss ehuss ehuss left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.