Skip to content

Snapshot clean-ups #64939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2019
Merged

Snapshot clean-ups #64939

merged 2 commits into from
Oct 10, 2019

Conversation

@nnethercote
Copy link
Contributor

Two minor clean-ups involving snapshots.

@nnethercote nnethercote requested a review from varkor October 1, 2019 02:51
@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2019
@nnethercote
Copy link
Contributor Author

r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned cramertj Oct 1, 2019
varkor
varkor reviewed Oct 1, 2019
View reviewed changes
@nnethercote
Clarify a comment in RegionConstraintCollector::leak_check.
3f9aea1
@nnethercote
Remove InferCtxt::in_snapshot().
1b41f95 
It's the same as `InferCtxt::commit_unconditionally()` except that it
is passed a snapshot and has a worse name.

The commit also changes `commit_unconditionally()` to receive a
snapshot, for consistency with `commit_if_ok()` and `probe()`.
@nnethercote
Copy link
Contributor Author

New code is up.

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned varkor Oct 8, 2019
nikomatsakis
nikomatsakis approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nnethercote

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 9, 2019

📌 Commit 1b41f95 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2019
@bors
Copy link
Collaborator

bors commented Oct 10, 2019

⌛ Testing commit 1b41f95 with merge aa45e03...

bors added a commit that referenced this pull request Oct 10, 2019
@bors
Auto merge of #64939 - nnethercote:snapshot-cleanups, r=nikomatsakis
aa45e03 
Snapshot clean-ups

Two minor clean-ups involving snapshots.
@bors
Copy link
Collaborator

bors commented Oct 10, 2019

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing aa45e03 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2019
@bors bors merged commit 1b41f95 into rust-lang:master Oct 10, 2019
@bors bors mentioned this pull request Oct 10, 2019
Merged
@nnethercote nnethercote deleted the snapshot-cleanups branch October 10, 2019 04:24
@nnethercote nnethercote mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

+1 more reviewer

@varkor varkor varkor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakis nikomatsakis

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote @rust-highfive @nikomatsakis @bors @varkor @cramertj