Current scheduler and I/O work #6513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will just use RAII for now.
This ended up touching a lot of code related to error handling.
Make names that better match rt::io. Return error types.
Put all uv code under rt::uv, as if it were in its own crate. Pull local_sched out of rt::sched.
Eliminates a lot of calls to `close`
…ween Scheduler and Task Called 'Tube' for lack of anything better.
Conflicts: src/libcore/logging.rs src/libcore/rt/local_services.rs src/libcore/rt/uv/mod.rs src/libcore/rt/uv/net.rs src/libcore/rt/uv/uvio.rs src/libcore/unstable.rs
…6377 Not necessary just yet but they make ARC not work.
It is more general-purpose than holding scheduler pointers
Some resolve problem is keeping the tests from working
|
It looks like a libuv upgrade will fix the mac deadlocks, so I'm going to close this again and try to ugrade uv. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 15, 2021
…pe, r=flip1995 Fix: Empty enum never type suggested only if the feature is enabled This PR addresses [Issue 6422](rust-lang/rust-clippy#6422). Instead of always recommending `never type` for empty enums, Clippy would only recommend [the lint](https://rust-lang.github.io/rust-clippy/master/index.html#empty_enum) if [LatePass.TyCtxt](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/context/struct.TyCtxt.html) has `features().never_type` enabled. - \[ ] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: Only trigger [`empty_enum`] lint if `never_type` feature is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r?
This rolls up my previous, unmerged pull request along with the last week's work. There is a lot of miscellaneous stuff here. Most of the issues that prevented the last pull from merging are resolved, but there is still a somewhat rare deadlock on mac that I'm hoping won't be too obnoxious if this lands. Still investigating.