Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Revert "Auto merge of #62948 - matklad:failable-file-loading, r=petro… #65273

Closed
wants to merge 1 commit into from

Commits on Oct 10, 2019

  1. Revert "Auto merge of rust-lang#62948 - matklad:failable-file-loading…

    …, r=petrochenkov"
    
    This reverts commit ef1ecbe, reversing
    changes made to fc8765d.
    
    That changed unfortunately broke rustfix on windows:
    
    rust-lang/rustfix#176
    
    Specifically, what ef1ecbe did was to
    enforce normalization of \r\n to \n at file loading time, similarly to
    how we deal with Byte Order Mark. Normalization changes raw offsets in
    files, which are exposed via `--error-format=json`, and used by rusfix.
    
    The proper solution here (which also handles the latent case with BOM) is
    
    rust-lang#65074
    
    However, since it's somewhat involved, and we are time sensitive, we
    prefer to revert the original change on beta.
    matklad committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    5a21f76 View commit details
    Browse the repository at this point in the history