Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print lifetimes with backticks #65292

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Conversation

JohnTitor
Copy link
Member

Fixes #65287

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2019
@varkor
Copy link
Member

varkor commented Oct 11, 2019

r=me when CI passes.

@Centril
Copy link
Contributor

Centril commented Oct 11, 2019

@JohnTitor can you please check that it also passes with --compare-mode=nll?

@JohnTitor
Copy link
Member Author

@Centril just checked and passed on my local

@JohnTitor
Copy link
Member Author

JohnTitor commented Oct 11, 2019

Ah, wait, I should commit with --bless

@Centril
Copy link
Contributor

Centril commented Oct 11, 2019

@bors r=varkor,Centril :)

@bors
Copy link
Contributor

bors commented Oct 11, 2019

📌 Commit 2ae5e34 has been approved by varkor,Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 14, 2019
bors added a commit that referenced this pull request Oct 14, 2019
Rollup of 7 pull requests

Successful merges:

 - #65215 (Add long error explanation for E0697)
 - #65292 (Print lifetimes with backticks)
 - #65362 (syntax: consolidate function parsing in item.rs)
 - #65363 (Remove implicit dependencies on syntax::pprust)
 - #65379 (refactor session::config::build_session_options_and_crate_config)
 - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering)
 - #65395 (Add some tests for fixed ICEs)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Oct 14, 2019
Rollup of 7 pull requests

Successful merges:

 - #65215 (Add long error explanation for E0697)
 - #65292 (Print lifetimes with backticks)
 - #65362 (syntax: consolidate function parsing in item.rs)
 - #65363 (Remove implicit dependencies on syntax::pprust)
 - #65379 (refactor session::config::build_session_options_and_crate_config)
 - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering)
 - #65395 (Add some tests for fixed ICEs)

Failed merges:

r? @ghost
@bors bors merged commit 2ae5e34 into rust-lang:master Oct 14, 2019
@JohnTitor JohnTitor deleted the add-backticks branch October 14, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lifetimes are inconsistently printed with backticks
5 participants