[Beta] Backport Clippy ICE fix to beta #65305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
|
Clippy branch for the backport is https://github.com/rust-lang/rust-clippy/tree/rust-1.39.0 |
|
The backport itself looks fine (just a note: rename the branch from @rust-lang/clippy do y'all approve this backport? Not sure how the approval process looks like in your team. |
pietroalbini
added
S-waiting-on-team
|
I renamed the branch. 👍 |
|
r+ |
|
@bors r+ |
|
📌 Commit 8aacf98 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 15, 2019
[Beta] Backport Clippy ICE fix to beta There was an ICE in Clippy, when compiling `mysql_common`. Since this is a pretty popular crate, and there were a bunch of Clippy issues in the last few days, I think it is worth it to backport the fix (rust-lang/rust-clippy#4590) to beta. cc rust-lang/rust-clippy#4653 r? @Manishearth
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an ICE in Clippy, when compiling
mysql_common. Since this is a pretty popular crate, and there were a bunch of Clippy issues in the last few days, I think it is worth it to backport the fix (rust-lang/rust-clippy#4590) to beta.cc rust-lang/rust-clippy#4653
r? @Manishearth