-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include const generic arguments in metadata #65365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Skinny121: this looks great, thank you! I'm really happy to see all the work you've been putting into fixing these const generics issues! :)
I just have one question, but I'm happy with these changes.
@Skinny121: if you could squash your two commits (as the second just undoes something in the first), that'd be great! |
3e303a4
to
eb68bbb
Compare
Thank you! @bors r+ rollup |
📌 Commit eb68bbb has been approved by |
…rkor Include const generic arguments in metadata Fixes rust-lang#64707 Fixes rust-lang#61624 Fixes rust-lang#64730 r? @varkor
Rollup of 10 pull requests Successful merges: - #65170 (rustc_metadata: Privatize private code and remove dead code) - #65260 (Optimize `LexicalResolve::expansion`.) - #65261 (Remove `Option` from `TokenStream`) - #65332 (std::fmt: reorder docs) - #65340 (Several changes to the codegen backend organization) - #65365 (Include const generic arguments in metadata) - #65398 (Bring attention to suggestions when the only difference is capitalization) - #65410 (syntax: add parser recovery for intersection- / and-patterns `p1 @ p2`) - #65415 (Remove an outdated test output file) - #65416 (Minor sync changes) Failed merges: r? @ghost
Fixes #64707
Fixes #61624
Fixes #64730
r? @varkor