Add File::with_options #65429
Merged
Add File::with_options #65429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
hellow554
reviewed
Oct 15, 2019
hellow554
reviewed
Oct 15, 2019
|
You do have to create one
|
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
spurious error? @shepmaster could you trigger the build process again? or even better: @Timmmm please squash and rebase your commits and then force push them :) |
|
That's docker hub problem: https://status.docker.com/pages/incident/533c6539221ae15e3f000031/5da5fc78c7b1c11cd8603721 |
This provides a more fluent API to create files with options, and also avoids the need to import OpenOptions.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
At last :-D Sorry for using the CI system as my build tool... Next time I will compile it myself! |
|
Ping from triage: @shepmaster Can you please review this PR? Thanks |
|
Pinging again from triage: @shepmaster Can you please review this PR? Thanks |
|
@bors r+ Seems like some libs folks were in favor of this on the associated RFC so we can probably move ahead here (it's an unstable feature anyway). |
|
📌 Commit c8150cb has been approved by |
bors
added
S-waiting-on-bors
tesuji
reviewed
Nov 2, 2019
| @@ -397,6 +399,37 @@ impl File { | |||
| OpenOptions::new().write(true).create(true).truncate(true).open(path.as_ref()) | |||
| } | |||
|
|
|||
| /// Returns a new OpenOptions object. | |||
There was a problem hiding this comment.
add link for this
Suggested change
| /// Returns a new OpenOptions object. | |
| /// Returns a new [OpenOptions] object. |
| /// open or create a file with specific options if `open()` or `create()` | ||
| /// are not appropriate. | ||
| /// | ||
| /// It is equivalent to `OpenOptions::new()` but allows you to write more |
There was a problem hiding this comment.
Suggested change
| /// It is equivalent to `OpenOptions::new()` but allows you to write more | |
| /// It is equivalent to [`OpenOptions::new()`] but allows you to write more |
| /// you can write `File::with_options().read(true).open("foo.txt"). This | ||
| /// also avoids the need to import `OpenOptions`. | ||
| /// | ||
| /// See the [`OpenOptions::new`] function for more details. |
There was a problem hiding this comment.
Suggested change
| /// See the [`OpenOptions::new`] function for more details. |
Comment on lines
+404
to
+406
| /// This function returns a new OpenOptions object that you can use to | ||
| /// open or create a file with specific options if `open()` or `create()` | ||
| /// are not appropriate. |
bors
added a commit
that referenced
this pull request
Nov 2, 2019
Add File::with_options This provides a more fluent API to create files with options, and also avoids the need to import OpenOptions. This implements @aldanor's [suggestion](rust-lang/rfcs#2615 (comment)) which was popular.
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a more fluent API to create files with options, and also avoids the need to import OpenOptions.
This implements @aldanor's suggestion which was popular.