-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #65430
Rollup of 4 pull requests #65430
Conversation
This factors out some duplicated code.
This commit removes an `Option` check in `BitIter::next()`, avoids calling `trailing_zeros()` when it's not necessary, and avoids the need for `enumerate()`. This gives a tiny (0.2%) instruction count win on a couple of benchmarks. The commit also adds some comments, which is good because this iteration code is moderately complex.
rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This commit just renames the DB variable from `db` to `diag` where it wasn't renamed.
Stabilize proc macros generating `macro_rules` items Fn-like and attribute proc macros can now generate `macro_rules` items. cc rust-lang#54727
…rochenkov syntax: misc extractions Part of rust-lang#65324. r? @petrochenkov
…kmdavis Optimize `BitIter` A minor speed improvement.
Refactor: Rename `db` locals to `diag` rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This PR just renames the db variable from `db` to `diag` where it wasn't renamed. r? @Mark-Simulacrum
📌 Commit b53e6d5 has been approved by |
⌛ Testing commit b53e6d5 with merge 28e7fff780d3af64337aad61c36aace798d26f76... |
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
macro_rules
items #64035 (Stabilize proc macros generatingmacro_rules
items)BitIter
#65425 (OptimizeBitIter
)db
locals todiag
#65428 (Refactor: Renamedb
locals todiag
)Failed merges:
r? @ghost