Fix #64153 #65435
Merged
Fix #64153 #65435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup=never (I have bad experience with adding -fulldeps tests) |
michaelwoerister
force-pushed
the
fix-issue-64153
branch
from
c7c33d7
to
83df393
Compare
Yes, I can imagine |
michaelwoerister
force-pushed
the
fix-issue-64153
branch
from
83df393
to
af05b23
Compare
|
@bors: r+ Seems reasonable to me! |
|
📌 Commit af05b23 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
…=alexcrichton Fix rust-lang#64153 This PR changes how the compiler detects if an object file from an upstream crate is a Rust object file or not. Instead of checking if the name starts with the crate name and ends with `.o` (which is not always the case, as described in rust-lang#64153), it now just checks if the filename ends with `.rcgu.o`. This fixes rust-lang#64153. However, ideally we'd clean up the code around filename generation some more. Then this check could be made more robust. r? @alexcrichton
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
…=alexcrichton Fix rust-lang#64153 This PR changes how the compiler detects if an object file from an upstream crate is a Rust object file or not. Instead of checking if the name starts with the crate name and ends with `.o` (which is not always the case, as described in rust-lang#64153), it now just checks if the filename ends with `.rcgu.o`. This fixes rust-lang#64153. However, ideally we'd clean up the code around filename generation some more. Then this check could be made more robust. r? @alexcrichton
bors
added
S-waiting-on-author
|
This probably fails because |
…to identify Rust generated object files.
michaelwoerister
force-pushed
the
fix-issue-64153
branch
from
af05b23
to
52eda13
Compare
|
I've switched the test from @bors r=alexcrichton |
|
📌 Commit 52eda13 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 52eda13 with merge 9d20e2f668a08e655cd20a838e9b3f447baabe03... |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
It's a network error. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 52eda13 with merge c3e2c99ed1b324674c598be9d919e48793039707... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
…s version is not worth the trouble.
|
Added @bors r=alexcrichton |
|
📌 Commit a63dfb3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 29, 2019
Fix #64153 This PR changes how the compiler detects if an object file from an upstream crate is a Rust object file or not. Instead of checking if the name starts with the crate name and ends with `.o` (which is not always the case, as described in #64153), it now just checks if the filename ends with `.rcgu.o`. This fixes #64153. However, ideally we'd clean up the code around filename generation some more. Then this check could be made more robust. r? @alexcrichton
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the compiler detects if an object file from an upstream crate is a Rust object file or not. Instead of checking if the name starts with the crate name and ends with
.o(which is not always the case, as described in #64153), it now just checks if the filename ends with.rcgu.o.This fixes #64153. However, ideally we'd clean up the code around filename generation some more. Then this check could be made more robust.
r? @alexcrichton