Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backtrace to 0.3.40 #65531

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Update backtrace to 0.3.40 #65531

merged 1 commit into from
Oct 29, 2019

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Oct 17, 2019 •
edited
Loading

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2019
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2019

📌 Commit db94656 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019
@mati865
Copy link
Contributor

mati865 commented Oct 18, 2019

It will fail because of cc bump, see #65445

tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65531 - tmandry:bump-backtrace, r=cramertj
772a8d2 
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
@tmandry tmandry mentioned this pull request Oct 18, 2019
Closed
@tmandry
Copy link
Member Author

tmandry commented Oct 18, 2019

@mati865 Thanks for pointing that out! @bors r- for now until we find a way to deal with this.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2019
@JohnCSimon
Copy link
Member

Ping from triage
@tmandry Can you please post the status of this PR?
cc: @cramertj

Thanks!

@mati865
Copy link
Contributor

mati865 commented Oct 26, 2019

@tmandry you can try using older cc crate, version 1.0.37 should be fine.

@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 28, 2019

📌 Commit d7f99da has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
@Centril
Rollup merge of rust-lang#65531 - tmandry:bump-backtrace, r=cramertj
0ae035b 
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
@Centril Centril mentioned this pull request Oct 29, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
@Centril
Rollup merge of rust-lang#65531 - tmandry:bump-backtrace, r=cramertj
f865095 
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
@Centril Centril mentioned this pull request Oct 29, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
@Centril
Rollup merge of rust-lang#65531 - tmandry:bump-backtrace, r=cramertj
ffc6225 
Update backtrace to 0.3.40

Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1

Pretty low risk, considering the only changes are in low-tier targets.

r? @cramertj
cc @alexcrichton
@Centril Centril mentioned this pull request Oct 29, 2019
Merged
bors added a commit that referenced this pull request Oct 29, 2019
@bors
Auto merge of #65919 - Centril:rollup-qrgwnt6, r=Centril
2dd4e73 
Rollup of 5 pull requests

Successful merges:

 - #65294 (Lint ignored `#[inline]` on function prototypes)
 - #65318 (Call out the types that are non local on E0117)
 - #65531 (Update backtrace to 0.3.40)
 - #65562 (Improve the "try using a variant of the expected type" hint.)
 - #65809 (Add new EFIAPI ABI)

Failed merges:

r? @ghost
@bors bors merged commit d7f99da into rust-lang:master Oct 29, 2019
@tmandry tmandry deleted the bump-backtrace branch March 2, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tmandry @cramertj @bors @mati865 @JohnCSimon @rust-highfive