Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #65588

Merged
merged 26 commits into from
Oct 19, 2019
Merged

Rollup of 6 pull requests #65588

merged 26 commits into from
Oct 19, 2019

Commits on Oct 6, 2019

  1. Fix zero-size uninitialized boxes

    Requesting a zero-size allocation is not allowed,
    return a dangling pointer instead.
    
    CC rust-lang#63291 (comment)
    SimonSapin committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    23d3ff1 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Configuration menu
    Copy the full SHA
    ca1cfda View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Configuration menu
    Copy the full SHA
    75f4dac View commit details
    Browse the repository at this point in the history
  2. Enable drain_filter

    ecstatic-morse committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    22a0856 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af691de View commit details
    Browse the repository at this point in the history
  4. Don't add argc and argv arguments to main on WASI.

    Add a target setting to allow targets to specify whether the generated
    `main` function should be passed `argc` and `argv` arguments. Set it
    to false on wasm32-wasi, since WASI's `args::args()` calls into the
    WASI APIs itself. This will allow the WASI toolchain to avoid linking
    and running command-line argument initialization code when the arguments
    aren't actually needed.
    sunfishcode committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    b25e323 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Configuration menu
    Copy the full SHA
    1101101 View commit details
    Browse the repository at this point in the history
  2. Use with in Symbol trait methods.

    Instead of `as_str()`, which unnecessarily involves `LocalInternedString`.
    nnethercote committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    d8fca9e View commit details
    Browse the repository at this point in the history
  3. Change how Symbol::Debug works.

    Currently, `Symbol::Debug` and `Symbol::Display` produce the same
    output; neither wraps the symbol in double quotes.
    
    This commit changes `Symbol::Debug` so it wraps the symbol in quotes.
    This change brings `Symbol`'s behaviour in line with `String` and
    `InternedString`. The change requires a couple of trivial test output
    adjustments.
    nnethercote committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    3532863 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f65a492 View commit details
    Browse the repository at this point in the history
  5. Remove Copy and Clone impls for LocalInternedString.

    They aren't used.
    nnethercote committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    0879f63 View commit details
    Browse the repository at this point in the history
  6. Remove Hash impls for DefPath, DisambiguatedDefPathData, and `D…

    …efKey`.
    
    They aren't used.
    nnethercote committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    d343ee8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    865c4bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bd813bf View commit details
    Browse the repository at this point in the history
  9. review comments

    estebank committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    2b76c8b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2d3c17a View commit details
    Browse the repository at this point in the history
  11. expand: Simplify expansion of derives

    And make it more uniform with other macros.
    By merging placeholders for future derives' outputs into the derive container's output fragment early.
    petrochenkov committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    7ce85f2 View commit details
    Browse the repository at this point in the history
  12. privacy: Avoid one more unwrap causing an ICE in rustdoc

    The issue is rustdoc-specific because its root cause if the `everybody_loops` pass makes some def-ids to not have local hir-ids
    petrochenkov committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    25cc99f View commit details
    Browse the repository at this point in the history
  13. Fix rebase

    petrochenkov committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    7f89f04 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    227db40 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. Rollup merge of rust-lang#65174 - SimonSapin:zero-box, r=alexcrichton

    Fix zero-size uninitialized boxes
    
    Requesting a zero-size allocation is not allowed, return a dangling pointer instead.
    
    CC rust-lang#63291 (comment)
    Centril authored Oct 19, 2019
    Configuration menu
    Copy the full SHA
    beec0a5 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#65252 - petrochenkov:deriveholders2, r=matt…

    …hewjasper
    
    expand: Simplify expansion of derives
    
    And make it more uniform with other macros.
    This is done by merging placeholders for future derives' outputs into the derive container's output fragment early (addressing FIXMEs from rust-lang#63667).
    
    Also, macros with names starting with `_` are no longer reported as unused, in accordance with the usual behavior of `unused` lints.
    
    r? @matthewjasper or @mark-i-m
    Centril authored Oct 19, 2019
    Configuration menu
    Copy the full SHA
    99603e9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#65485 - ecstatic-morse:const-validation-mis…

    …match-ugliness, r=eddyb
    
    Suppress ICE when validators disagree on `LiveDrop`s in presence of `&mut`
    
    Resolves rust-lang#65394.
    
    This hack disables the validator mismatch ICE in cases where a `MutBorrow` error has been emitted by both validators, but they don't agree on the number of `LiveDrop` errors.
    
    The new validator is more conservative about whether a value is moved from in the presence of mutable borrows. For example, the new validator will emit a `LiveDrop` error on the following code.
    
    ```rust
    const _: Vec<i32> = {
        let mut x = Vec::new();
        let px = &mut x as *mut _;
        let y = x;
        unsafe { ptr::write(px, Vec::new()); }
        y
    };
    ```
    
    This code is not UB AFAIK (it passes MIRI at least). The current validator does not emit a `LiveDrop` error for `x` upon exit from the initializer. `x` is not actually dropped, so I think this is correct? A proper fix for this would require a new `MaybeInitializedLocals` dataflow analysis or maybe a relaxation of the existing `IndirectlyMutableLocals` one.
    
    r? @RalfJung
    Centril authored Oct 19, 2019
    Configuration menu
    Copy the full SHA
    27f8c79 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#65542 - estebank:kill-static-methods, r=Cen…

    …tril
    
    Refer to "associated functions" instead of "static methods"
    
    Fix rust-lang#59782.
    Centril authored Oct 19, 2019
    Configuration menu
    Copy the full SHA
    fab7404 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#65545 - nnethercote:more-symbol-cleanups, r…

    …=petrochenkov
    
    More symbol cleanups
    
    Some minor improvements, mostly aimed at reducing unimportant differences between `Symbol` and `InternedString`. Helps a little with rust-lang#60869.
    
    r? @petrochenkov
    Centril authored Oct 19, 2019
    Configuration menu
    Copy the full SHA
    ed4c2c2 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#65576 - sunfishcode:main-needs-argc-argv, r…

    …=alexcrichton
    
    Don't add `argc` and `argv` arguments to `main` on WASI.
    
    Add a target setting to allow targets to specify whether the generated
    `main` function should be passed `argc` and `argv` arguments. Set it
    to false on wasm32-wasi, since WASI's `args::args()` calls into the
    WASI APIs itself. This will allow the WASI toolchain to avoid linking
    and running command-line argument initialization code when the arguments
    aren't actually needed.
    Centril authored Oct 19, 2019
    Configuration menu
    Copy the full SHA
    3e1da91 View commit details
    Browse the repository at this point in the history