Remove unreachable unit tuple compare binop codegen #65605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @eddyb |
|
@bors r+ rollup |
|
📌 Commit 2e36c84 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 20, 2019
Remove unreachable unit tuple compare binop codegen Closes rust-lang#63906 Fixes rust-lang#63551 This is based on rust-lang#63906 by @luigisHat, who had trouble with rebasing his PR.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 20, 2019
Remove unreachable unit tuple compare binop codegen Closes rust-lang#63906 Fixes rust-lang#63551 This is based on rust-lang#63906 by @luigisHat, who had trouble with rebasing his PR.
bors
added a commit
that referenced
this pull request
Oct 20, 2019
Rollup of 5 pull requests Successful merges: - #65460 (Clean up `contains()` `insert()` chains on HashSet) - #65463 (Avoid unnecessary arena allocations in `expand_pattern()`.) - #65579 (Changed `resolve_type_vars_with_obligations` to also resolve const inference variables) - #65605 (Remove unreachable unit tuple compare binop codegen) - #65626 (trivial typo fix) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63906
Fixes #63551
This is based on #63906 by @luigisHat, who had trouble with rebasing his PR.