Fix canonicalize_const_var leaking inference variables
#65652
Merged
+68
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
BenLewis-Seequent
changed the title
canonicalize_const_var from leaking inference variablescanonicalize_const_var leaking inference variables
eddyb
approved these changes
Oct 21, 2019
|
This is great, thanks! |
|
📌 Commit aa3d28f has been approved by |
bors
added
S-waiting-on-bors
|
@Skinny121: fantastic, thank you so much! I had completely overlooked this — great spot! |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 21, 2019
Fix `canonicalize_const_var` leaking inference variables Fixes rust-lang#61338 Fixes rust-lang#61516 Fixes rust-lang#62536 Fixes rust-lang#64087 Fixes rust-lang#64863 Fixes rust-lang#65623 I added regression tests for all these issues apart from rust-lang#64863, which is very similar to rust-lang#61338. r? @varkor
bors
added a commit
that referenced
this pull request
Oct 21, 2019
Rollup of 5 pull requests Successful merges: - #65544 (Added doc on keyword break) - #65620 (Correctly note code as Ok not error for E0573) - #65624 ([mir-opt] Improve SimplifyLocals pass so it can remove unused consts) - #65650 (use unwrap_or in lint code) - #65652 (Fix `canonicalize_const_var` leaking inference variables) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Oct 21, 2019
Rollup of 5 pull requests Successful merges: - #65544 (Added doc on keyword break) - #65620 (Correctly note code as Ok not error for E0573) - #65624 ([mir-opt] Improve SimplifyLocals pass so it can remove unused consts) - #65650 (use unwrap_or in lint code) - #65652 (Fix `canonicalize_const_var` leaking inference variables) Failed merges: r? @ghost
5 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61338
Fixes #61516
Fixes #62536
Fixes #64087
Fixes #64863
Fixes #65623
I added regression tests for all these issues apart from #64863, which is very similar to #61338.
r? @varkor