Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InternedString #65657

Merged
merged 7 commits into from
Oct 24, 2019
Merged

Remove InternedString #65657

merged 7 commits into from
Oct 24, 2019

Commits on Oct 21, 2019

  1. Convert some InternedStrings to Symbols. 

    This avoids the needs for various conversions, and makes the code
slightly faster, because `Symbol` comparisons and hashing is faster.
    @nnethercote
    nnethercote committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    02edd14 View commit details
    Browse the repository at this point in the history

  2. Convert InternedStrings to Symbols in UnsafetyViolation.

    @nnethercote
    nnethercote committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    c325553 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary impl Clean<String> for InternedString.

    @nnethercote
    nnethercote committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    78c3427 View commit details
    Browse the repository at this point in the history

  4. Convert fields within DefPathData from InternedString to Symbol. 

    It's a full conversion, except in `DefKey::compute_stable_hash()` where
a `Symbol` now is converted to an `InternedString` before being hashed.
This was necessary to avoid test failures.
    @nnethercote
    nnethercote committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    b8214e9 View commit details
    Browse the repository at this point in the history

  5. Change SymbolName::name from InternedString to Symbol. 

    This requires changing the `PartialOrd`/`Ord` implementations to look at
the chars rather than the symbol index.
    @nnethercote
    nnethercote committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    dddacf1 View commit details
    Browse the repository at this point in the history

  6. Use Symbol for codegen unit names. 

    This is a straightforward replacement except for two places where we
have to convert to `LocalInternedString` to get a stable sort.
    @nnethercote
    nnethercote committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    2da7a9c View commit details
    Browse the repository at this point in the history

  7. Remove InternedString. 

    By using `LocalInternedString` instead for the few remaining uses.
    @nnethercote
    nnethercote committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    08e2f05 View commit details
    Browse the repository at this point in the history