Update Source Code Pro and include italics #65665
Conversation
Can you say how much it will increase? |
|
Reproducing the table in the issue below. Updating the upright fonts to the latest version costs an extra 79 KiB, and including the italics costs 82 KiB, total increase is 161 KiB. I believe this shouldn't be such an issue, especially with caching.
|
JohnCSimon
added
the
S-waiting-on-author
|
@JohnCSimon I think you got the wrong label. |
Dylan-DPC-zz
added
S-waiting-on-review
|
Ping from triage |
|
So we're doubling the size of the font to add italic if I understood correctly? |
|
Basically adding about 75% current size to add italic, and this PR also adds another 75% to update the upright and bold to the latest version, so it's a 150% increase in total (from 110 kb to 275 kb). |
|
I'm not sure if it's worth it... Any additional opinion @rust-lang/rustdoc ? |
|
Ping from Triage: Any updates @rust-lang/rustdoc @GuillaumeGomez @tspiteri? |
|
I think we should merge this. If we're going to ship custom fonts they should at least be up to date and complete. |
|
📌 Commit ea9519b has been approved by |
bors
added
S-waiting-on-bors
…dePro, r=GuillaumeGomez Update Source Code Pro and include italics Fixes rust-lang#65502. A few notes: * As stated in rust-lang#65502, this does increase the download size. * Since this PR changes the font set, I think docs.rs would have to be updated if this PR is merged. * The fonts have a double extension (.ttf.woff); this is to keep the names consistent with the upstream font release which does that to distinguish these from the .otf.woff files ([Source Code Pro otf renders poorly on older Windows system apps](adobe-fonts/source-code-pro#25 (comment))).
|
@GuillaumeGomez Great! When this is merged I think docs.rs has to be updated, though I couldn't figure out how that works in rust-lang/docs.rs#270. |
Rollup of 8 pull requests Successful merges: - #65665 (Update Source Code Pro and include italics) - #66478 (rustc_plugin: Remove the compatibility shim) - #66497 (Fix #53820) - #66526 (Add more context to `async fn` trait error) - #66532 (Generate DWARF address ranges for faster lookups) - #66546 (Remove duplicate function) - #66548 ([RISCV] Disable Atomics on all Non-A RISC-V targets) - #66553 (remove HermitCore leftovers from sys/unix) Failed merges: r? @ghost
|
Don't worry, let them handle their part. ;) |
|
This broke font rendering on firefox on macos with the dark theme. See #60365 (comment) for details. Can we maybe have a different solution?
|
|
Aargh! @GuillaumeGomez Should I open a PR to revert this PR? |
|
Yes please. |
|
Considering it's broken, I already open the PR to revert it here. |
This comment has been minimized.
This comment has been minimized.
…dePro, r=GuillaumeGomez Update Source Code Pro and include italics Fixes rust-lang#65502. rust-lang#65665, a similar PR to this was merged but reverted because of rust-lang#65665 (comment). The issue in that comment is the upstream issue adobe-fonts/source-code-pro#217 which should now be fixed in the upstream since [2.032R-ro/1.052R-it/1.012R-VAR release](https://github.com/adobe-fonts/source-code-pro/releases/tag/2.032R-ro/1.052R-it/1.012R-VAR), so I think this can now be merged. A couple of notes from the original PR: * Since this PR changes the font set, I think docs.rs would have to be updated if this PR is merged. * The fonts have a double extension (.ttf.woff); this is to keep the names consistent with the upstream font release which does that to distinguish these from the .otf.woff files (Source Code Pro otf renders poorly on older Windows system apps).
Fixes #65502.
A few notes: