Fix unresolved type span inside async object #65668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Does this change have a user visible change? |
|
@estebank error[E0698]: type inside `async` object must be known in this context
--> src/lib.rs:23:25
|
23 | let server = server.serve(hyper::service::make_service_fn(move |_| {
| ^^^^^ cannot infer type for `ME`
|
note: the type is part of the `async` object because of this `await`
--> src/lib.rs:34:5
|
34 | server.await
| ^^^^^^^^^^^^To: error[E0698]: type inside `async fn` body must be known in this context
--> src/lib.rs:15:13
|
15 | Ok(hyper::service::service_fn(move |req| {
| ^^ cannot infer type for `ME`
|
note: the type is part of the `async fn` body because of this `await`
--> src/lib.rs:24:5
|
24 | server.await
| ^^^^^^^^^^^^
error: aborting due to previous errorbut I should figure out a test/ui. |
tesuji
reviewed
Oct 22, 2019
|
r=me with a test |
|
Looks good to me, too |
|
Ping from triage. |
|
@csmoe can you add a ui test exercising this new code? |
|
@estebank it's a bit complicated, still trying. |
JohnCSimon
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #66252) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Pinging once again from triage: Thank you. |
JohnCSimon
added
the
S-inactive
|
Triage: @csmoe - unfortunately this PR has sat idle for several weeks, I'm marking this as inactive. Please reopen this PR when you're ready to move forward. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 19, 2019
Fix unresolved type span inside async object Closes rust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 20, 2019
Fix unresolved type span inside async object Closes rust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 20, 2019
Fix unresolved type span inside async object Closes rust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65180
r? @estebank
cc @nikomatsakis @cramertj