Transition future compat lints to {ERROR, DENY} - Take 2 #65785

Centril · 2019-10-25T00:55:40Z

Follow up to #63247 implementing #63247 (comment).

legacy_ctor_visibility (ERROR) -- closes Tracking issue for legacy_constructor_visibility compatibility lint #39207
legacy_directory_ownership (ERROR) -- closes legacy_directory_ownership future-compatibility warnings #37872
safe_extern_static (ERROR) -- closes Tracking issue for safe_extern_statics compatibility lint #36247
parenthesized_params_in_types_and_modules (ERROR) -- closes parenthesized_params_in_types_and_modules future-compatibility warnings #42238
duplicate_macro_exports (ERROR)
nested_impl_trait (ERROR) -- closes Tracking issue for nested_impl_trait compatibility lint #59014
ill_formed_attribute_input (DENY) -- transitions Tracking issue for future-incompatibility lint ill_formed_attribute_input #57571
patterns_in_fns_without_body (DENY) -- transitions Tracking issue for future-incompatibility lint patterns_in_fns_without_body #35203

Centril · 2019-10-25T08:22:44Z

The PR builder is finally happy. 🎉

src/libsyntax/attr/builtin.rs

petrochenkov · 2019-10-25T20:22:02Z

Also, legacy_ctor_visibility had a large number of regressions in the crater run in #63247, but most of them from unstable syntex_syntax (expected function, found struct ast::Name), so it should be ok.

Centril · 2019-10-27T15:39:15Z

@petrochenkov @varkor This should be ready again for review now.

oli-obk · 2019-11-06T12:20:42Z

I'm all for this, but the precedent also had fix-PRs open for the crates that will break and did a reverse dependency analysis.

I know that doing so is a lot of work, but we do have our stability story. Picking an arbitrary threshold (like 5) of broken crates where it's ok to go to an error, seems a bit odd to me. Then again, we have to do this PR at some point and the forward compat lints have been triggering for a while.

I'm unsure how to proceed, thus my question about talking this through in a team meeting or just giving everyone a chance to sign off or comment.

oli-obk · 2019-11-08T12:30:24Z

Seems like all the crates affected are abandoned (which would explain why they haven't been fixed).

@bors r+

bors · 2019-11-08T12:30:26Z

📌 Commit 574d2b8 has been approved by oli-obk

@varkor

Transition future compat lints to {ERROR, DENY} - Take 2 Follow up to rust-lang#63247 implementing rust-lang#63247 (comment). - `legacy_ctor_visibility` (ERROR) -- closes rust-lang#39207 - `legacy_directory_ownership` (ERROR) -- closes rust-lang#37872 - `safe_extern_static` (ERROR) -- closes rust-lang#36247 - `parenthesized_params_in_types_and_modules` (ERROR) -- closes rust-lang#42238 - `duplicate_macro_exports` (ERROR) - `nested_impl_trait` (ERROR) -- closes rust-lang#59014 - `ill_formed_attribute_input` (DENY) -- transitions rust-lang#57571 - `patterns_in_fns_without_body` (DENY) -- transitions rust-lang#35203 r? @varkor cc @petrochenkov

bors · 2019-11-08T15:43:41Z

⌛ Testing commit 574d2b8 with merge 230ebbbe9d0ea2faf5fe586b8f3f049b6f571c4b...

@varkor

Transition future compat lints to {ERROR, DENY} - Take 2 Follow up to rust-lang#63247 implementing rust-lang#63247 (comment). - `legacy_ctor_visibility` (ERROR) -- closes rust-lang#39207 - `legacy_directory_ownership` (ERROR) -- closes rust-lang#37872 - `safe_extern_static` (ERROR) -- closes rust-lang#36247 - `parenthesized_params_in_types_and_modules` (ERROR) -- closes rust-lang#42238 - `duplicate_macro_exports` (ERROR) - `nested_impl_trait` (ERROR) -- closes rust-lang#59014 - `ill_formed_attribute_input` (DENY) -- transitions rust-lang#57571 - `patterns_in_fns_without_body` (DENY) -- transitions rust-lang#35203 r? @varkor cc @petrochenkov

Centril · 2019-11-08T15:52:08Z

@bors retry rolled up.

@ghost

Rollup of 5 pull requests Successful merges: - #65785 (Transition future compat lints to {ERROR, DENY} - Take 2) - #66007 (Remove "here" from "expected one of X here") - #66043 (rename Memory::get methods to get_raw to indicate their unchecked nature) - #66154 (miri: Rename to_{u,i}size to to_machine_{u,i}size) - #66188 (`MethodSig` -> `FnSig` & Use it in `ItemKind::Fn`) Failed merges: r? @ghost

bors · 2019-11-08T19:10:06Z

⌛ Testing commit 574d2b8 with merge 1465351c3dbabfa79ff87afa4e90c34d77be68ae...

rust-highfive · 2019-11-08T19:12:12Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

resolve: Minor cleanup of duplicate macro reexports Enabled by rust-lang#65785 which changed `duplicate_macro_exports` from a lint to a hard error.

It was not initially clear to me why, after changing `.filter(...).next()` to `.find(...)`, the borrow checker as of Rust 1.41.1 required me to inline `all.lines()` at this point : error[E0596]: cannot borrow `lines` as mutable, as it is not declared as mutable --> tyrga-bin/../build.rs:53:33 | 52 | let lines = all.lines(); | ----- help: consider changing this to be mutable: `mut lines` 53 | let wrote = lines | ^^^^^ cannot borrow as mutable error: aborting due to previous error For more information about this error, try `rustc --explain E0596`. but it [appears][0] that the new error is [expected][1], and that if I had been using `.find()` previously instead of `.filter(...).next()`, I would have seen a non-fatal "compat" lint under previous compiler versions, leading me in the same direction. [0]: rust-lang/rust#68729 [1]: rust-lang/rust#65785

The panics are removed as rust-lang/rust#65785 has made them an error and the compiler will complain anyway for ill formed attributes. The use _could_ allow them, technically. But this doesn't really exist: https://github.com/search?q=allow%28ill_formed_attribute_input%29&type=code Shows 4 occurences at time of commit. I would also think that users that enable this, should know what they are doing ;) Signed-off-by: Marcel Müller <neikos@neikos.email>

rust-highfive assigned varkor Oct 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2019

Centril force-pushed the compat-to-error-2 branch from 4b41197 to a512b6c Compare October 25, 2019 01:00

Centril changed the title ~~[WIP] Transition future compat lints to {ERROR, DENY} - Take 2~~ Transition future compat lints to {ERROR, DENY} - Take 2 Oct 25, 2019

Centril force-pushed the compat-to-error-2 branch from a512b6c to adfa047 Compare October 25, 2019 01:19

This comment has been minimized.

Sign in to view

Centril force-pushed the compat-to-error-2 branch from adfa047 to af3b20a Compare October 25, 2019 03:51

petrochenkov self-assigned this Oct 25, 2019

This comment has been minimized.

Sign in to view

Centril force-pushed the compat-to-error-2 branch from af3b20a to f193001 Compare October 25, 2019 05:59

petrochenkov reviewed Oct 25, 2019

View reviewed changes

src/libsyntax/attr/builtin.rs Outdated Show resolved Hide resolved

petrochenkov removed their assignment Oct 25, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019

Centril force-pushed the compat-to-error-2 branch from f193001 to 165f3f1 Compare October 27, 2019 15:36

Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2019

This comment has been minimized.

Sign in to view

Centril force-pushed the compat-to-error-2 branch from 165f3f1 to 2b4565c Compare October 28, 2019 20:42

This comment has been minimized.

Sign in to view

Centril force-pushed the compat-to-error-2 branch from 3f90669 to f1c5b42 Compare November 6, 2019 07:11

This comment has been minimized.

Sign in to view

Centril added 2 commits November 6, 2019 11:08

legacy_ctor_visibility -> error

c0056c0

legacy_directory_ownership -> error

79b35e9

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2019

Centril mentioned this pull request Nov 8, 2019

Rollup of 5 pull requests #66218

Closed

Centril mentioned this pull request Nov 8, 2019

Rollup of 5 pull requests #66225

Merged

bors merged commit 574d2b8 into rust-lang:master Nov 8, 2019

Centril deleted the compat-to-error-2 branch November 8, 2019 19:12

This was referenced Nov 8, 2019

Tracking issue for future-incompatibility lint ill_formed_attribute_input #57571

Open

Tracking issue for future-incompatibility lint patterns_in_fns_without_body #35203

Open

petrochenkov mentioned this pull request Dec 28, 2019

resolve: Minor cleanup of duplicate macro reexports #67677

Merged

This was referenced Jan 30, 2020

Dependence on syntex_syntax causes breakage as of nightly-2019-11-09. jmacdonald/amp#173

Closed

Unable to compile syntex_syntax using Rust 1.41 #68729

Closed

petrochenkov mentioned this pull request Mar 11, 2020

ICE on inconsistent resolution for a macro #69932

Closed

ehuss mentioned this pull request Apr 21, 2020

duplicate_macro_exports lint says it will be a hard error in 2018 but it is still a lint #61221

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transition future compat lints to {ERROR, DENY} - Take 2 #65785

Transition future compat lints to {ERROR, DENY} - Take 2 #65785

Centril commented Oct 25, 2019 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

Centril commented Oct 25, 2019

petrochenkov commented Oct 25, 2019

Centril commented Oct 27, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Nov 6, 2019

oli-obk commented Nov 8, 2019

bors commented Nov 8, 2019

bors commented Nov 8, 2019

Centril commented Nov 8, 2019

bors commented Nov 8, 2019

rust-highfive commented Nov 8, 2019

Transition future compat lints to {ERROR, DENY} - Take 2 #65785

Transition future compat lints to {ERROR, DENY} - Take 2 #65785

Conversation

Centril commented Oct 25, 2019 • edited Loading

This comment has been minimized.

This comment has been minimized.

Centril commented Oct 25, 2019

petrochenkov commented Oct 25, 2019

Centril commented Oct 27, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Nov 6, 2019

oli-obk commented Nov 8, 2019

bors commented Nov 8, 2019

bors commented Nov 8, 2019

Centril commented Nov 8, 2019

bors commented Nov 8, 2019

rust-highfive commented Nov 8, 2019

Centril commented Oct 25, 2019 •

edited

Loading