doc: explain why it is unsafe to construct Vec<u8> from Vec<u16> #65873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
| /// to build a `Vec<u8>` from a pointer to a C `char` array with length `size_t`, | ||
| /// or a `Vec<u16>` and its length. Because the allocator cares about the alignment. | ||
| /// The buffer was allocated with alignment 2 (for `u16`), but after | ||
| /// turning it into a `Vec<u8>` it'll be deallocated with alignment 1. |
There was a problem hiding this comment.
This reads just a little off; I would say
/// to build a `Vec<u8>` from a pointer to a C `char` array with length `size_t`.
/// It's also not safe to build one from a `Vec<u16>` and its length, because
/// the allocator cares about the alignment, and these two types have different
/// alignments. The buffer was allocated with alignment 2 (for `u16`), but after
/// turning it into a `Vec<u8>` it'll be deallocated with alignment 1.
tesuji
force-pushed
the
doc-vec-from-raw-parts
branch
from
70abb60
to
c44f752
Compare
Co-authored-by: Steve Klabnik <steve@steveklabnik.com>
tesuji
force-pushed
the
doc-vec-from-raw-parts
branch
from
c44f752
to
3f98078
Compare
|
@bors r+ rollup Thanks! |
|
📌 Commit 3f98078 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 27, 2019
…ruppe doc: explain why it is unsafe to construct Vec<u8> from Vec<u16>
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 28, 2019
…ruppe doc: explain why it is unsafe to construct Vec<u8> from Vec<u16>
bors
added a commit
that referenced
this pull request
Oct 28, 2019
Rollup of 6 pull requests Successful merges: - #64747 (Stabilize `Option::flatten`) - #65664 (`std::panic::Location` is a lang_item, add `core::intrinsics::caller_location` (RFC 2091 3/N)) - #65792 (rustc, rustc_passes: reduce deps on rustc_expand) - #65849 (librustc_lexer: Enhance documentation) - #65873 (doc: explain why it is unsafe to construct Vec<u8> from Vec<u16>) - #65880 (Gather together usefulness tests) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.